Skip to content

Commit 0340d15

Browse files
committed
Update deployment karma configs to use pre-compiled test files
Remove resolve and commonjs plugins from rollup preprocessor since they were trying to resolve and bundle the jspdf.es.js import. Instead, use a simple external function to mark the jspdf.es.js import as external, which preserves the relative import path exactly as written. This allows the browser to resolve the import at runtime using Karma's file serving, which is what asyncImportHelper needs.
1 parent 59fc527 commit 0340d15

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

test/deployment/esm/karma.conf.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
const karmaConfig = require("../../karma.common.conf.js");
2-
const resolve = require("rollup-plugin-node-resolve");
3-
const commonjs = require("rollup-plugin-commonjs");
42
const { babel } = require("@rollup/plugin-babel");
53

64
module.exports = config => {
@@ -59,11 +57,9 @@ module.exports = config => {
5957
babelHelpers: "bundled",
6058
extensions: [".ts", ".js"],
6159
presets: ["@babel/preset-typescript"]
62-
}),
63-
resolve(),
64-
commonjs()
60+
})
6561
],
66-
external: [/^\.\.?\//], // Mark relative paths as external
62+
external: (id) => id.includes('dist/jspdf.es.js'),
6763
output: {
6864
format: "esm",
6965
sourcemap: "inline"

test/unit/karma.conf.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Karma configuration
22
"use strict";
33
const karmaConfig = require("../karma.common.conf.js");
4-
const resolve = require("rollup-plugin-node-resolve");
5-
const commonjs = require("rollup-plugin-commonjs");
64
const { babel } = require("@rollup/plugin-babel");
75

86
module.exports = config => {
@@ -45,11 +43,9 @@ module.exports = config => {
4543
babelHelpers: "bundled",
4644
extensions: [".ts", ".js"],
4745
presets: ["@babel/preset-typescript"]
48-
}),
49-
resolve(),
50-
commonjs()
46+
})
5147
],
52-
external: [/^\.\.?\//], // Mark relative paths as external
48+
external: (id) => id.includes('dist/jspdf.es.js'),
5349
output: {
5450
format: "esm",
5551
sourcemap: "inline"

0 commit comments

Comments
 (0)