refactor: OpenRewrite recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <team@moderne.io>

Author: 2 people

src/main/java/org/openrewrite/staticanalysis/ExplicitLambdaArgumentTypes.java

@@ -188,9 +188,11 @@ private J.VariableDeclarations maybeAddTypeExpression(J.VariableDeclarations mul
                     currentType = ((JavaType.Array) currentType).getElemType();
                 }
                 return result;
-            } else if (type instanceof JavaType.Variable) {
+            }
+            if (type instanceof JavaType.Variable) {
                 return buildTypeTree(((JavaType.Variable) type).getType(), space);
-            } else if (type instanceof JavaType.GenericTypeVariable) {
+            }
+            if (type instanceof JavaType.GenericTypeVariable) {
                 JavaType.GenericTypeVariable genericType = (JavaType.GenericTypeVariable) type;
 
                 if (!genericType.getName().equals("?")) {

src/main/java/org/openrewrite/staticanalysis/JavaElementFactory.java

@@ -162,11 +162,14 @@ static J.MemberReference newInstanceMethodReference(Expression containing, Strin
         }
         if (type instanceof JavaType.GenericTypeVariable) {
             return getClassType(((JavaType.GenericTypeVariable) type).getBounds().get(0));
-        } else if (type instanceof JavaType.Array) {
+        }
+        if (type instanceof JavaType.Array) {
             return getClassType(((JavaType.Array) type).getElemType());
-        } else if (type instanceof JavaType.Variable) {
+        }
+        if (type instanceof JavaType.Variable) {
             return getClassType(((JavaType.Variable) type).getOwner());
-        } else if (type instanceof JavaType.Method) {
+        }
+        if (type instanceof JavaType.Method) {
             return getClassType(((JavaType.Method) type).getDeclaringType());
         }
         return null;

src/main/resources/META-INF/rewrite/examples.yml

@@ -3536,6 +3536,32 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.staticanalysis.UnwrapElseAfterReturn
+examples:
+- description: ''
+  sources:
+  - before: |
+      class Test {
+          int foo(boolean condition) {
+              if (condition) {
+                  return 1;
+              } else {
+                  return 2;
+              }
+          }
+      }
+    after: |
+      class Test {
+          int foo(boolean condition) {
+              if (condition) {
+                  return 1;
+              }
+              return 2;
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.staticanalysis.UnwrapRepeatableAnnotations
 examples:
 - description: ''