migrate ProFormA uploader from carrierwave to ActiveStorage

Author: kkoehn

app/controllers/exercises_controller.rb

@@ -161,9 +161,8 @@ def import_start
 
     uuid = ProformaService::UuidFromZip.call(zip: zip_file)
     exists, updatable = uuid_check(user: current_user, uuid:).values_at(:uuid_found, :update_right)
-
-    uploader = ProformaZipUploader.new
-    uploader.cache!(params[:file])
+    key = SecureRandom.hex
+    ActiveStorage::Blob.create_and_upload!(key:, io: zip_file, filename: zip_file.original_filename)
 
     message = if exists && updatable
                 t('.exercise_exists_and_is_updatable')
@@ -177,7 +176,7 @@ def import_start
       status: 'success',
       message:,
       actions: render_to_string(partial: 'import_actions',
-        locals: {exercise: @exercise, imported: false, exists:, updatable:, file_id: uploader.cache_name}),
+        locals: {exercise: @exercise, imported: false, exists:, updatable:, file_id: key}),
     }
   rescue ProformaXML::InvalidZip => e
     render json: {
@@ -187,16 +186,16 @@ def import_start
   end
 
   def import_confirm
-    uploader = ProformaZipUploader.new
-    uploader.retrieve_from_cache!(params[:file_id])
-    exercise = ::ProformaService::Import.call(zip: uploader.file, user: current_user)
-    exercise.save!
+    ActiveStorage::Blob.find_by(key: params[:file_id]).open do |zip|
+      exercise = ::ProformaService::Import.call(zip:, user: current_user)
+      exercise.save!
 
-    render json: {
-      status: 'success',
-      message: t('.success'),
-      actions: render_to_string(partial: 'import_actions', locals: {exercise:, imported: true}),
-    }
+      render json: {
+        status: 'success',
+        message: t('.success'),
+        actions: render_to_string(partial: 'import_actions', locals: {exercise:, imported: true}),
+      }
+    end
   rescue ProformaXML::ProformaError, ActiveRecord::RecordInvalid => e
     render json: {
       status: 'failure',

app/uploaders/proforma_zip_uploader.rb

@@ -589,21 +589,21 @@
   describe 'POST #import_start' do
     let(:valid_file) { fixture_file_upload('proforma_import/testfile.zip', 'application/zip') }
     let(:invalid_file) { 'invalid_file' }
-    let(:mock_uploader) { instance_double(ProformaZipUploader) }
     let(:uuid) { 'mocked-uuid' }
     let(:post_request) { post :import_start, params: {file: file} }
     let(:file) { valid_file }
 
     before do
       allow(controller).to receive(:current_user).and_return(user)
-      allow(ProformaZipUploader).to receive(:new).and_return(mock_uploader)
     end
 
     context 'when the file is valid' do
       before do
         allow(ProformaService::UuidFromZip).to receive(:call).and_return(uuid)
-        allow(mock_uploader).to receive(:cache!)
-        allow(mock_uploader).to receive(:cache_name).and_return('mocked-cache-name')
+      end
+
+      it 'saves the file to the server' do
+        expect { post_request }.to change(ActiveStorage::Blob, :count).by(1)
       end
 
       context 'when the exercise exists and is updatable' do
@@ -658,6 +658,10 @@
     context 'when the file is invalid' do
       let(:file) { invalid_file }
 
+      it 'does not save the file to the server' do
+        expect { post_request }.not_to change(ActiveStorage::Blob, :count)
+      end
+
       it 'renders failure JSON with correct error' do
         post_request
 
@@ -685,16 +689,10 @@
 
   describe 'POST #import_confirm' do
     let(:file_id) { 'file_id' }
-    let(:mock_uploader) { instance_double(ProformaZipUploader, file: 'mocked_file') }
     let(:post_request) { post :import_confirm, params: {file_id: file_id} }
 
-    before do
-      allow(ProformaZipUploader).to receive(:new).and_return(mock_uploader)
-    end
-
     context 'when the import is successful' do
       before do
-        allow(mock_uploader).to receive(:retrieve_from_cache!).with(file_id)
         allow(ProformaService::Import).to receive(:call).with(zip: 'mocked_file', user: user).and_return(exercise)
         allow(exercise).to receive(:save!).and_return(true)
       end
@@ -711,7 +709,6 @@
 
     context 'when ProformaError or validation error occurs' do
       before do
-        allow(mock_uploader).to receive(:retrieve_from_cache!).with(file_id)
         allow(ProformaService::Import).to receive(:call).and_raise(ProformaXML::ProformaError, 'Proforma error')
       end
 
@@ -727,7 +724,6 @@
 
     context 'when StandardError occurs' do
       before do
-        allow(mock_uploader).to receive(:retrieve_from_cache!).and_raise(StandardError, 'Unexpected error')
         allow(Sentry).to receive(:capture_exception)
       end