fix(scripts): support paths with spaces for npm run compile #6055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paths with spaces are incorrectly split into multiple tokens by cp.spawn() Script should be portable across all platforms and path configurations without `shell: true`: 1. The target binaries (pbjs, pbts) executable 2. npm automatically creates platform-specific wrappers when installing packages with bin entries 3. Node.js cp.spawn() automatically handles cross-platform compatibility
btomaj
force-pushed
the
fix-compile-in-path-with-spaces
branch
from
e270c5b to
18bba3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
npm run compilefails if path contains spaces.Short description of the changes
shell: truewas removed fromexec()in./scripts/generate-protos.jsType of change
How Has This Been Tested?
npm run compileruns in path with spaces.Checklist:
Unit tests and documentation are not applicable