-
Notifications
You must be signed in to change notification settings - Fork 913
support ExtendedOpenTelemetry in GlobalOpenTelemetry #7799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
support ExtendedOpenTelemetry in GlobalOpenTelemetry #7799
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7799 +/- ##
============================================
- Coverage 90.16% 90.15% -0.01%
- Complexity 7202 7205 +3
============================================
Files 816 817 +1
Lines 21737 21757 +20
Branches 2130 2131 +1
============================================
+ Hits 19599 19615 +16
- Misses 1468 1472 +4
Partials 670 670 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jack-berg we missed that in the last PR on extended open telemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Thanks!
| Method getOpenTelemetrySdk = | ||
| openTelemetrySdkAutoConfiguration.getMethod("getOpenTelemetrySdk"); | ||
| return new ObfuscatedOpenTelemetry( | ||
| return IncubatingUtil.obfuscatedOpenTelemetry( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#nit: I think we should consider moving the logic from IncubatingUtil.obfuscatedOpenTelemetry into GlobalOpenTelemetry. Its a bit jarring to see code that looks like it will be using incubating code even when the incubator is not present. Also allows the standard ObfuscatedOpenTelemetry class to stay put here. It looks like its incubating when it lives as an inner class of IncubatingUtil.
Follow up to #7496