Filter object fields to only check one related_object_type per COT in _has_circular_reference

Author: bctiemann

netbox_custom_objects/api/serializers.py

@@ -57,6 +57,7 @@ class Meta:
             "related_object_type",
             "app_label",
             "model",
+            "group_name",
         )
 
     def validate(self, attrs):

netbox_custom_objects/models.py

@@ -1071,6 +1071,7 @@ def _has_circular_reference(self, custom_object_type, visited):
         visited.add(custom_object_type.id)
 
         # Check all object and multiobject fields in this custom object type
+        related_objects_checked = set()
         for field in custom_object_type.fields.filter(
             type__in=[
                 CustomFieldTypeChoices.TYPE_OBJECT,
@@ -1079,6 +1080,9 @@ def _has_circular_reference(self, custom_object_type, visited):
             related_object_type__isnull=False,
             related_object_type__app_label=APP_LABEL
         ):
+            if field.related_object_type in related_objects_checked:
+                continue
+            related_objects_checked.add(field.related_object_type)
 
             # Get the related custom object type directly from the object_type relationship
             try: