What could cause the Dialogue Manager test scene to automatically close?

[JoseA-byte]

Before adding Dialogue Manager to my project, I created another separate project where I tested and modified certain aspects of the Dialogue Manager. However, when I copied and pasted the add-on folder into my project to import the modifications I made, it automatically closed when I tried to open the add-on test scene.

However, nothing has been changed in the code in this copy compared to the original from the other project. Furthermore, when I instantiate a balloon in another scene, it displays no errors and works with the modifications I made. I really don't know what could be happening, although I didn't give it importance because I can test the dialogues elsewhere, but it is a bit annoying to be able to use the test scene.

[Fireye04]

Do have a repo with your fork or any sort of diff of your changes compared to upstream? GDM is pretty big and this could be any number of things. I would have no way to know without looking at the specific changes.

[Fireye04]

Ok I reset my GDM branch to base 3.7.1 and here's the diff file.

diff.txt

Let me know if you based your changes off a different commit than this one: 1c259aa so I can get a more accurate diff, otherwise I'll get digging.

[Fireye04]

Ok so as it stands I can't actually test the thing, as I get an array of errors when trying to use it in an actual project but I believe I can narrow the issue to this:

godot_dialogue_manager/addons/dialogue_manager/views/main_view.gd

Line 839 in ab00116

func run_test_scene(from_key: String) -> void:

I believe it's line 838 in your iteration, but the runner runs up the test scene here:

https://github.com/nathanhoad/godot_dialogue_manager/blob/main/addons/dialogue_manager/test_scene.gd

which then tries to call show_dialogue_balloon() but fails due to the method signature no longer matching the modified version. (a string called style is now required.) Adding in that style string should probably get it working again.

[JoseA-byte]

It is not the same as 1c259aa, and it is true that I did not realize that I had passed a value for the style, but I have put it and it still closes automatically

[JoseA-byte]

class_name BaseDialogueTestScene extends Node2D

const DialogueSettings = preload("./settings.gd")
const DialogueResource = preload("./dialogue_resource.gd")
var style: String = ""

@onready var title: String = DialogueSettings.get_user_value("run_title")
@onready var resource: DialogueResource = load(DialogueSettings.get_user_value("run_resource_path"))

func _ready():
if not Engine.is_embedded_in_editor:
var window: Window = get_viewport()
var screen_index: int = DisplayServer.get_primary_screen()
window.position = Vector2(DisplayServer.screen_get_position(screen_index)) + (DisplayServer.screen_get_size(screen_index) - window.size) * 0.5
window.mode = Window.MODE_WINDOWED

# Normally you can just call DialogueManager directly but doing so before the plugin has been
# enabled in settings will throw a compiler error here so I'm using `get_singleton` instead.
var dialogue_manager = Engine.get_singleton("DialogueManager")
dialogue_manager.dialogue_ended.connect(_on_dialogue_ended)
dialogue_manager.show_dialogue_balloon(resource, style, title if not title.is_empty() else resource.first_title)

func _enter_tree() -> void:
DialogueSettings.set_user_value("is_running_test_scene", false)

#region Signals

func _on_dialogue_ended(_resource: DialogueResource):
get_tree().quit()

#endregion

#In this way, but its behavior does not change

[Fireye04]

Can you get the test scene running on its own and can you paste the log output?

[JoseA-byte]

Okay, let me tell you, I ran the test scene independently with the style change in the show_dialogue_balloon function. And it played the last dialog I tried to open in main. So I thought the problem might be something I moved from main_view.gd (although I don't remember doing that). I looked for the code from the other version and put it in this one, but the error remains the same. So, could main.view be the cause?

[Fireye04]

I think that's more than likely the case. This method:

godot_dialogue_manager/addons/dialogue_manager/views/main_view.gd

Line 839 in ab00116

func run_test_scene(from_key: String) -> void:

Is most likely the culprit here, though I'm not certain exactly what it could be doing to mess up the test scene instantiation in your modified version.

[JoseA-byte]

Another strange thing happened: while removing the main_view code and pasting the original, it didn't report an error once, but I didn't pay much attention to it, and it didn't reappear. Since this is getting very complicated, I'm going to save the changes I made to the add-on, delete it, and re-download it into the project to see if that resolves everything. Then, add the changes I made again. Thanks for the help.