Add records without replacing all existing ones #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/patch dns records
test/change-only-request-method
|
(@n3integration Canary - is this project alive?) |
Grigoriy0
added a commit
to Grigoriy0/terraform-provider-godaddy
that referenced
this pull request
Apr 30, 2025
Grigoriy0
added a commit
to Grigoriy0/terraform-provider-godaddy
that referenced
this pull request
Apr 30, 2025
Grigoriy0
added a commit
to Grigoriy0/terraform-provider-godaddy
that referenced
this pull request
Apr 30, 2025
Grigoriy0
added a commit
to Grigoriy0/terraform-provider-godaddy
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the context of this PR?
It gives the ability to select if the resource records will be just added to godaddy or if they will replace existing records.
Adds
overwritebool property to record resource:If set to
trueit will replace all records on godaddy with the list or records provided in the resource (existing functionality)If set to
falseit will only add the provided records without affecting any of the existing onesSplits
UpdateDomainRecordsto two functions, one that replaces records (existing functionality) and one that only adds records.Based on the godaddy records API documentation:
Implements provider read function to update terraform state after the creation of the new records
TF docs
Adds Terraform docs plugin to automatically generate docs
Upgrades go to latest version 1.19
Issues addressed in this PR