Skip to content

feat: change on_accept in ProtocolHandler to better deal with 0rtt connections #3611

@rklaehn

Description

@rklaehn

To handle 0rtt connections you have to do the entire handling of the connection in on_accepting, since it returns a Connection, but you do get a IncomingZeroRttConnection.

In light of this, 1. the on_accepting name is not really that fitting anymore. Also, there is no way to signal that you have successfully completed except obtaining a Connection from the IncomingZeroRttConnection via handshake_completed after the connection is already closed.

So we should either rename on_accepting and make it return an Option, or rethink the IncomingZeroRttConnection newtype.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions