Skip to content

Kitsu tracker uses remote_id incorrectly #2605

@cpiber

Description

@cpiber

Steps to reproduce

  1. Add Kitsu tracking to a title
  2. Open DB
  3. Notice that the entry has remote_id set, but not to the remote manga ID, but rather to the library entry ID, which should be library_id (which is empty)

Expected behavior

remote_id should be the remote manga ID
library_id should be the handle to update the user's library data

Actual behavior

The entry has remote_id set, but not to the remote manga ID, but rather to the library entry ID, which should be library_id (which is empty)

Crash logs

No response

Mihon version

v0.19.1

Android version

Android 11

Device

Other details

Only Kitsu appears to have this problem. Other trackers appear to either properly use library_id, or not require this in the first place. The MAL API for example expects the manga ID, not a separate library ID for updating user data. Which is also likely where this bug came from, since bind is suspiciously similar between those two.

This was originally noticed in Suwayomi. Mihon does not appear to use those IDs outside of the respective tracker. I would work on a PR to update the usage (with a migration to properly set those fields for existing track entries).

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.19.1.
  • I have filled out all of the requested information in this form, including specific version numbers.
  • I understand that Mihon does not have or fix any extensions, and I will not receive help for any issues related to sources or extensions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions