Fix Boolean Mismatch Error for treat_urls_as_media and trust_remote_code #33
Conversation
| func normalizeIndexSettings(state *IndexResourceModel, newState *IndexResourceModel) { | ||
| // Handle boolean defaults | ||
| if state.Settings.TreatUrlsAndPointersAsMedia.IsNull() && | ||
| !newState.Settings.TreatUrlsAndPointersAsMedia.ValueBool() { |
There was a problem hiding this comment.
If newState.Settings.TreatUrlsAndPointersAsMedia.ValueBool() falsey if the boolean value is set to false? If so, this logic would be wrong, so want to check.
| return nil, false | ||
| } | ||
|
|
||
| func normalizeIndexSettings(state *IndexResourceModel, newState *IndexResourceModel) { |
There was a problem hiding this comment.
This feels very brittle to changes in schema. In the worst case, adding new fields could potentially cause existing indexes to be deleted if we don't update this function.
Feels like it should have a more systematic solution, i.e. walk the newState fields and descendant fields, and propagate nullish values.
There was a problem hiding this comment.
I thought so as well. So I'm not super happy with it yet.
problems:
- user does not define these fields so they are null
- api returns default values
- mismatch between null and the default values
Manual Solutions I've tried
- set incoming fields to null if they are null locally (not ideal, want to show full state to user)
- set undefined fields with the default value before create (not good, default value drift from cloud is a possibility)
Both don't seem appealing.
I'm looking for a way to indicate to terraform that some fields will be undefined in the user's statefile but should be expected from the api. Looking through the terraform documentation I've found this which seems to fit the function
| var ( | ||
| _ resource.Resource = &indicesResource{} | ||
| _ resource.ResourceWithConfigure = &indicesResource{} | ||
| //_ resource.ResourceWithModifyPlan = &indicesResource{} |
There was a problem hiding this comment.
wait this isnt ready for review yet haha
| //Computed: true, | ||
| //PlanModifiers: []planmodifier.String{ | ||
| // stringplanmodifier.UseStateForUnknown(), | ||
| //}, |
No description provided.