Merge pull request #214 from learnweb/fix/anonymousmail

Hotfix for anonymous Mail

Author: TamaroWalter

CHANGES.md

@@ -1,6 +1,10 @@
 CHANGELOG
 =========
 
+4.5.1 (2025-05-19)
+------------------
+[HOTFIX] #214
+
 4.5.0 (2025-05-06)
 ------------------
-* Moodle 4.5 compatible version
+* Moodle 4.5 compatible version

classes/output/moodleoverflow_email.php

@@ -358,7 +358,7 @@ public function get_discussionname() {
      * @return string
      */
     public function get_author_fullname() {
-        if (anonymous::is_post_anonymous($this->discussion, $this->moodleoverflow, $this->author->id)) {
+        if ($this->author->anonymous) {
             return get_string('privacy:anonym_user_name', 'mod_moodleoverflow');
         } else {
             return fullname($this->author, $this->viewfullnames);
@@ -521,7 +521,7 @@ public function get_moodleoverflowviewlink() {
      * @return string
      */
     public function get_authorlink() {
-        if (anonymous::is_post_anonymous($this->discussion, $this->moodleoverflow, $this->author->id)) {
+        if ($this->author->anonymous) {
             return null;
         }
 
@@ -542,7 +542,7 @@ public function get_authorlink() {
      */
     public function get_author_picture() {
         global $OUTPUT;
-        if (anonymous::is_post_anonymous($this->discussion, $this->moodleoverflow, $this->author->id)) {
+        if ($this->author->anonymous) {
             return '';
         }
 
@@ -555,7 +555,7 @@ public function get_author_picture() {
      * @return string
      */
     public function get_group_picture() {
-        if (anonymous::is_post_anonymous($this->discussion, $this->moodleoverflow, $this->author->id)) {
+        if ($this->author->anonymous) {
             return '';
         }
 

classes/task/send_mails.php

@@ -25,6 +25,7 @@
 namespace mod_moodleoverflow\task;
 
 use core\session\exception;
+use mod_moodleoverflow\anonymous;
 use mod_moodleoverflow\output\moodleoverflow_email;
 
 defined('MOODLE_INTERNAL') || die();
@@ -122,6 +123,7 @@ public function send_review_notifications() {
 
             $post = $postinfo;
             $userfrom = \core_user::get_user($postinfo->userid, '*', MUST_EXIST);
+            $userfrom->anonymous = anonymous::is_post_anonymous($discussion, $moodleoverflow, $postinfo->userid);
 
             foreach ($usersto as $userto) {
                 try {

externallib.php

@@ -22,6 +22,7 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
+use mod_moodleoverflow\anonymous;
 use mod_moodleoverflow\output\moodleoverflow_email;
 use mod_moodleoverflow\review;
 
@@ -121,7 +122,7 @@ public static function record_vote($postid, $ratingid) {
         $ownerrating = \mod_moodleoverflow\ratings::moodleoverflow_get_reputation($moodleoverflow->id, $postownerid);
         $raterrating = \mod_moodleoverflow\ratings::moodleoverflow_get_reputation($moodleoverflow->id, $USER->id);
 
-        $cannotseeowner = \mod_moodleoverflow\anonymous::is_post_anonymous($discussion, $moodleoverflow, $USER->id) &&
+        $cannotseeowner = anonymous::is_post_anonymous($discussion, $moodleoverflow, $USER->id) &&
             $USER->id != $postownerid;
 
         $params['postrating'] = $rating->upvotes - $rating->downvotes;
@@ -254,6 +255,7 @@ public static function review_reject_post($postid, $reason = null) {
         $renderertext = $PAGE->get_renderer('mod_moodleoverflow', 'email', 'textemail');
 
         $userto = core_user::get_user($post->userid);
+        $userto->anonymous = anonymous::is_post_anonymous($discussion, $moodleoverflow, $post->userid);
 
         $maildata = new moodleoverflow_email(
                 $course,

lib.php

@@ -820,17 +820,20 @@ function moodleoverflow_send_mails() {
 
                 if (\mod_moodleoverflow\anonymous::is_post_anonymous($discussion, $moodleoverflow, $post->userid)) {
                     $userfrom = \core_user::get_noreply_user();
+                    $userfrom->anonymous = true;
                 } else {
                     // Check whether the sending user is cached already.
                     if (array_key_exists($post->userid, $users)) {
                         $userfrom = $users[$post->userid];
+                        $userfrom->anonymous = false;
                     } else {
                         // We dont know the the user yet.
 
                         // Retrieve the user from the database.
                         $userfrom = $DB->get_record('user', ['id' => $post->userid]);
                         if ($userfrom) {
                             moodleoverflow_minimise_user_record($userfrom);
+                            $userfrom->anonymous = false;
                         } else {
                             $uid = $post->userid;
                             $pid = $post->id;
@@ -1093,7 +1096,7 @@ function moodleoverflow_mark_old_posts_as_mailed($endtime) {
  *
  * @param stdClass $user
  */
-function moodleoverflow_minimise_user_record(stdClass $user) {
+function moodleoverflow_minimise_user_record(stdClass &$user) {
 
     // Remove all information for the mail generation that are not needed.
     unset($user->institution);

templates/email_text.mustache

@@ -72,7 +72,7 @@
 {{{ coursename }}} -> {{#str}} moodleoverflows, moodleoverflow {{/str}} -> {{{ moodleoverflowname }}}{{#showdiscussionname}} -> {{{ discussionname }}} {{/showdiscussionname}}
 {{ permalink }}
 {{{ subject }}}
-{{#str}} bynameondate, moodleoverflow, {
+{{#str}} bynameondatenorating, moodleoverflow, {
 "name": {{#quote}}{{{ authorfullname }}}{{/quote}},
 "date": {{#quote}}{{ postdate }}{{/quote}}
 } {{/str}}

version.php

@@ -28,8 +28,8 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->component = 'mod_moodleoverflow';
-$plugin->version   = 2025050600;
-$plugin->requires  = 2022112800;
-$plugin->release = 'v4.5-r1';
+$plugin->version = 2025050601;
+$plugin->requires = 2022112800;
+$plugin->release = 'v4.5-r2';
 $plugin->supported = [401, 405];
 $plugin->maturity = MATURITY_STABLE;