ALT+C don't print on cd

[omnigenous]

ALT+C prints builtin cd -- PATH when directory is selected

Could I change this so it doesn't print anything and just silently change dir?

[aorith]

You can re-define the cd function AFTER you source the shell key-bindings.
For example, for bash you can just redirect the output to /dev/null:

__fzf_cd__() {
  local dir
  dir=$(
    FZF_DEFAULT_COMMAND=${FZF_ALT_C_COMMAND:-} \
    FZF_DEFAULT_OPTS=$(__fzf_defaults "--reverse --walker=dir,follow,hidden --scheme=path" "${FZF_ALT_C_OPTS-} +m") \
    FZF_DEFAULT_OPTS_FILE='' $(__fzfcmd)
  ) && printf 'builtin cd -- %q' "$(builtin unset CDPATH && builtin cd -- "$dir" && builtin pwd)" >/dev/null
}

Source: https://github.com/junegunn/fzf/blob/master/shell/key-bindings.bash#L72

EDIT: for zsh it is more involved, this seems to work:

fzf-cd-widget() {
  setopt localoptions pipefail no_aliases 2> /dev/null
  local dir="$(
    FZF_DEFAULT_COMMAND=${FZF_ALT_C_COMMAND:-} \
    FZF_DEFAULT_OPTS=$(__fzf_defaults "--reverse --walker=dir,follow,hidden --scheme=path" "${FZF_ALT_C_OPTS-} +m") \
    FZF_DEFAULT_OPTS_FILE='' $(__fzfcmd) < /dev/tty)"
  if [[ -z "$dir" ]]; then
    zle redisplay
    return 0
  fi
  zle push-line # Clear buffer. Auto-restored on next prompt.
  builtin cd -- ${(q)dir:a} >/dev/null
  local ret=$?
  unset dir # ensure this doesn't end up appearing in prompt expansion
  zle reset-prompt
  return $ret
}

Source: https://github.com/junegunn/fzf/blob/master/shell/key-bindings.zsh#L110-L113

[omnigenous]

Thanks, that did it! I'm also still curious why fzf maintainers write it to buffer by default.

[moritzdietz]

One quirk though. In your solution you also removed zle accept-line

     return 0
   fi
   zle push-line # Clear buffer. Auto-restored on next prompt.
-  BUFFER="builtin cd -- ${(q)dir:a}"
-  zle accept-line
+  builtin cd -- ${(q)dir:a} >/dev/null
   local ret=$?
   unset dir # ensure this doesn't end up appearing in prompt expansion
   zle reset-prompt

At least for me in my setup this resulted in the following:

1. Press ALT+C in my current path
2. Select a dir and press ENTER -> no change in PS1
3. Press ENTER again to get a new prompt which updates my PS1 to reflect the new dir
   

For me to get a better visual behavior, the only change needed to fix OPs problem was to update the config like so:

     return 0
   fi
   zle push-line # Clear buffer. Auto-restored on next prompt.
-  BUFFER="builtin cd -- ${(q)dir:a}"
+  builtin cd -- ${(q)dir:a} >/dev/null
   zle accept-line
   local ret=$?
   unset dir # ensure this doesn't end up appearing in prompt expansion

After re-adding the line this will look like this:

I have tested this with vanilla ZSH as well as OMZ + p10k and this indeed solves this problem. I am about to open a new issue to see if this is something we can fix in the default keybinds.

[moritzdietz]

Ah I see, you do loose Shell history when doing this. So the current implementation ensures that ALT + C writes the directory change to ZSH history.

[moritzdietz]

It all boils down to this: #3641 (comment)