only set topic conf when needed (#32)

Author: nick-zh

src/Conf/KafkaConfiguration.php

@@ -4,6 +4,7 @@
 
 namespace Jobcloud\Kafka\Conf;
 
+use Jobcloud\Kafka\Consumer\KafkaConsumerBuilder;
 use Jobcloud\Kafka\Consumer\TopicSubscription;
 use RdKafka\Conf as RdKafkaConf;
 use RdKafka\TopicConf as RdKafkaTopicConf;
@@ -21,6 +22,11 @@ class KafkaConfiguration extends RdKafkaConf
      */
     protected $topicSubscriptions;
 
+    /**
+     * @var string
+     */
+    private $type;
+
     /**
      * @var array<string,int>
      */
@@ -33,14 +39,15 @@ class KafkaConfiguration extends RdKafkaConf
      * @param string[] $brokers
      * @param array|TopicSubscription[] $topicSubscriptions
      * @param mixed[] $config
+     * @param string $type
      */
-    public function __construct(array $brokers, array $topicSubscriptions, array $config = [])
+    public function __construct(array $brokers, array $topicSubscriptions, array $config = [], string $type = '')
     {
         parent::__construct();
 
         $this->brokers = $brokers;
         $this->topicSubscriptions = $topicSubscriptions;
-
+        $this->type = $type;
         $this->initializeConfig($config);
     }
 
@@ -81,7 +88,10 @@ protected function initializeConfig(array $config = []): void
                 continue;
             }
 
-            if (true === $this->isLowLevelTopicConfSetting($name)) {
+            if (
+                KafkaConsumerBuilder::CONSUMER_TYPE_LOW_LEVEL === $this->type
+                && true === $this->isLowLevelTopicConfSetting($name)
+            ) {
                 $topicConf->set($name, (string) $value);
                 $this->setDefaultTopicConf($topicConf);
             }

src/Consumer/KafkaConsumerBuilder.php

@@ -303,7 +303,8 @@ public function build(): KafkaConsumerInterface
         $kafkaConfig = new KafkaConfiguration(
             $this->brokers,
             $this->topics,
-            $this->config
+            $this->config,
+            $this->consumerType
         );
 
         //set consumer callbacks

tests/Unit/Conf/KafkaConfigurationTest.php

@@ -2,6 +2,7 @@
 
 namespace Jobcloud\Kafka\Tests\Unit\Kafka\Conf;
 
+use Jobcloud\Kafka\Consumer\KafkaConsumerBuilder;
 use Jobcloud\Kafka\Consumer\TopicSubscription;
 use Jobcloud\Kafka\Conf\KafkaConfiguration;
 use PHPUnit\Framework\TestCase;
@@ -97,7 +98,8 @@ public function testConfigValues($inputValue, $expectedValue): void
             [
                 'group.id' => $inputValue,
                 'auto.commit.interval.ms' => 100
-            ]
+            ],
+            KafkaConsumerBuilder::CONSUMER_TYPE_LOW_LEVEL
         );
 
         $config = $kafkaConfiguration->getConfiguration();