Merge pull request #2350 from torgeiru/remove-arch-prctl-call

Removing arch_prctl from syscall and creating architecture specific musl calls

Author: alfreb

deps/musl/default.nix

@@ -27,6 +27,9 @@ stdenv.mkDerivation rec {
     cp ${./patches/includeos_syscalls.h} $sourceRoot/src/internal/includeos_syscalls.h
     cp ${./patches/syscall.h} $sourceRoot/src/internal/syscall.h
 
+    rm $sourceRoot/src/thread/x86_64/__set_thread_area.s
+    cp ${./patches/__set_thread_area.c} $sourceRoot/src/thread/x86_64/__set_thread_area.c
+
     rm $sourceRoot/arch/x86_64/syscall_arch.h
     rm $sourceRoot/arch/i386/syscall_arch.h
   '';

deps/musl/patches/__set_thread_area.c

@@ -0,0 +1,8 @@
+#include "syscall.h"
+
+#define ARCH_SET_FS 0x1002
+
+int __set_thread_area(void *p)
+{
+    return __syscall(SYS_arch_prctl, ARCH_SET_FS, p);
+}

src/arch/aarch64/CMakeLists.txt

@@ -7,6 +7,7 @@ set(ARCH_OBJECTS
 #  profile_intr.asm
 #  apic_asm.asm
   arch_start.asm
+  arch_musl.cpp
   exceptions.asm
 #  interrupts.asm
 #  fiber.asm
@@ -15,7 +16,6 @@ set(ARCH_SOURCES
   paging.cpp
   cpu.cpp
   timer.cpp
-  syscall_entry.cpp
 )
 enable_language(ASM)
 

src/arch/aarch64/arch_musl.cpp

@@ -0,0 +1,15 @@
+#include <os>
+#include <errno.h>
+#include "cpu.hpp"
+
+extern "C"
+long syscall_SYS_set_thread_area(struct user_desc *u_desc) {
+  set_tpidr(u_info); // This probably still does not work
+  return 0;
+}
+
+extern "C"
+long syscall_SYS_arch_prctl(int code, uintptr_t ptr) {
+  os::panic("Arch_prctl is specific to x86!");
+  return -ENOSYS;
+}

src/arch/aarch64/syscall_entry.cpp

@@ -6,6 +6,7 @@ set(ARCH_OBJECTS
   profile_intr.asm
   apic_asm.asm
   arch_start.asm
+  arch_musl.cpp
   exceptions.asm
   interrupts.asm
   fiber.asm

src/arch/i686/CMakeLists.txt

@@ -0,0 +1,15 @@
+#include <os>
+#include <errno.h>
+
+extern "C"
+long syscall_SYS_set_thread_area(struct user_desc *u_info)
+{
+  os::panic("Libc not supported for 32 bit currently!");
+  return -ENOSYS;
+}
+
+extern "C"
+long syscall_SYS_arch_prctl(int code, uintptr_t ptr) {
+  os::panic("Libc not supported for 32 bit currently!");
+  return -ENOSYS;
+}

src/arch/i686/arch_musl.cpp

@@ -5,6 +5,7 @@ set(ARCH_OBJECTS
   apic_asm.asm
   apic_longmode.asm
   arch_start.asm
+  arch_musl.cpp
   exceptions.asm
   interrupts.asm
   fiber_asm.asm

src/arch/x86_64/CMakeLists.txt

@@ -0,0 +1,34 @@
+#include <os>
+#include <errno.h>
+#include <likely>
+#include <arch/x86/cpu.hpp>
+
+extern "C"
+long syscall_SYS_set_thread_area(struct user_desc *u_desc) {
+  os::panic("Setting thread pointer on 64 bit Intel/AMD should go via arch_prctl!");
+  return -ENOSYS;
+}
+
+#define ARCH_SET_GS 0x1001
+#define ARCH_SET_FS 0x1002
+#define ARCH_GET_FS 0x1003
+#define ARCH_GET_GS 0x1004
+
+extern "C"
+long syscall_SYS_arch_prctl(int code, uintptr_t ptr) {
+  switch(code){
+  case ARCH_SET_GS:
+    if (UNLIKELY(!ptr)) return -EINVAL;
+    x86::CPU::set_gs((void*)ptr);
+    break;
+  case ARCH_SET_FS:
+    if (UNLIKELY(!ptr)) return -EINVAL;
+    x86::CPU::set_fs((void*)ptr);
+    break;
+  case ARCH_GET_GS:
+    os::panic("<arch_prctl> GET_GS called!\n");
+  case ARCH_GET_FS:
+    os::panic("<arch_prctl> GET_FS called!\n");
+  }
+  return 0;
+}

src/arch/x86_64/arch_musl.cpp

@@ -14,63 +14,16 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include <arch/x86/cpu.hpp>
 #include <os.hpp>
-#include <likely>
 #include <kprint>
-#include <errno.h>
-
-#define ARCH_SET_GS 0x1001
-#define ARCH_SET_FS 0x1002
-#define ARCH_GET_FS 0x1003
-#define ARCH_GET_GS 0x1004
-
-#ifdef __x86_64__
-static long sys_prctl(int code, uintptr_t ptr)
-{
-  switch(code){
-  case ARCH_SET_GS:
-    //kprintf("<arch_prctl> set_gs to %#lx\n", ptr);
-    if (UNLIKELY(!ptr)) return -EINVAL;
-    x86::CPU::set_gs((void*)ptr);
-    break;
-  case ARCH_SET_FS:
-    //kprintf("<arch_prctl> set_fs to %#lx\n", ptr);
-    if (UNLIKELY(!ptr)) return -EINVAL;
-    x86::CPU::set_fs((void*)ptr);
-    break;
-  case ARCH_GET_GS:
-    os::panic("<arch_prctl> GET_GS called!\n");
-  case ARCH_GET_FS:
-    os::panic("<arch_prctl> GET_FS called!\n");
-  }
-  return -EINVAL;
-}
-#endif
 
 extern "C"
 uintptr_t syscall_entry(uint64_t n, uint64_t a1, uint64_t a2, uint64_t a3,
                    uint64_t a4, uint64_t a5)
 {
-  switch(n) {
-  case 158: // arch_prctl
-    sys_prctl(a1, a2);
-    break;
-  default:
-    kprintf("<syscall entry> no %lu (a1=%#lx a2=%#lx a3=%#lx a4=%#lx a5=%#lx) \n",
+  kprintf("<syscall entry> no %lu (a1=%#lx a2=%#lx a3=%#lx a4=%#lx a5=%#lx) \n",
             n, a1, a2, a3, a4, a5);
-  }
+  os::panic("Syscalls are not implemented in IncludeOS!");
   return 0;
 }
 
-extern "C"
-long syscall_SYS_set_thread_area(struct user_desc *u_info)
-{
-  if (UNLIKELY(!u_info)) return -EINVAL;
-#ifdef __x86_64__
-  x86::CPU::set_fs(u_info);
-#else
-  x86::CPU::set_gs(u_info);
-#endif
-  return 0;
-}