[DX-1939] fixed compiler errors encountered in unreal engine 5.4 (#97)

* fix: apdated code to new c++ standard

* fix: fixed text formating

* chore: minor method improvement

* fix: reworked labmda's capture

* fix: moved template method implementation to header file

Author: YermekG

Source/Immutable/Private/Immutable/ImmutableDataTypes.cpp

@@ -17,9 +17,9 @@ FString FImmutablePassportInitData::ToJsonString() const
 	}
 	// Remove redirectUri field if it's empty so that the bridge doesn't try to
 	// use it
-	if (Wrapper.JsonObject->HasField("redirectUri") && Wrapper.JsonObject->GetStringField("redirectUri").IsEmpty())
+	if (Wrapper.JsonObject->HasField(TEXT("redirectUri")) && Wrapper.JsonObject->GetStringField(TEXT("redirectUri")).IsEmpty())
 	{
-		Wrapper.JsonObject->RemoveField("redirectUri");
+		Wrapper.JsonObject->RemoveField(TEXT("redirectUri"));
 	}
 	Wrapper.JsonObjectToString(OutString);
 

Source/Immutable/Private/Immutable/ImmutablePassport.cpp

@@ -188,7 +188,7 @@ void UImmutablePassport::HasStoredCredentials(const FImtblPassportResponseDelega
 {
 	// we do check credentials into two steps, we check accessToken and then IdToken
 	// check access token
-	CallJS(ImmutablePassportAction::GetAccessToken, TEXT(""), ResponseDelegate, FImtblJSResponseDelegate::CreateLambda([=](FImtblJSResponse Response)
+	CallJS(ImmutablePassportAction::GetAccessToken, TEXT(""), ResponseDelegate, FImtblJSResponseDelegate::CreateLambda([this, ResponseDelegate](FImtblJSResponse Response)
 	{
 		FString AccessToken;
 

Source/Immutable/Private/Immutable/ImmutableRequests.cpp

@@ -39,10 +39,10 @@ FString FImxBatchNftTransferRequest::ToJsonString() const
 		return "";
 	}
 
-	if (Wrapper.JsonObject->HasField("nftTransferDetails"))
+	if (Wrapper.JsonObject->HasField(TEXT("nftTransferDetails")))
 	{
 		const auto Writer = TJsonWriterFactory<TCHAR, TCondensedJsonPrintPolicy<TCHAR>>::Create(&OutString);
-		FJsonSerializer::Serialize(Wrapper.JsonObject->GetArrayField("nftTransferDetails"), Writer);
+		FJsonSerializer::Serialize(Wrapper.JsonObject->GetArrayField(TEXT("nftTransferDetails")), Writer);
 		IMTBL_LOG("FImxBatchNftTransferRequest Serialised: %s", *OutString);
 		Writer->Close();
 	}

Source/Immutable/Private/Immutable/ImmutableSubsystem.cpp

@@ -56,16 +56,6 @@ void UImmutableSubsystem::Deinitialize()
 	Super::Deinitialize();
 }
 
-template <class UserClass>
-#if (ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 1)
-void UImmutableSubsystem::WhenReady(UserClass* Object, typename FImmutableSubsystemReadyDelegate::FDelegate::TMethodPtr<UserClass> Func)
-#else
-void UImmutableSubsystem::WhenReady(UserClass* Object, typename FImmutableSubsystemReadyDelegate::FDelegate::TUObjectMethodDelegate<UserClass>::FMethodPtr Func)
-#endif
-{
-	OnReady.AddUObject(Object, Func);
-}
-
 void UImmutableSubsystem::OnBridgeReady()
 {
 	// When the bridge is ready our subsystem is ready to be used by game code.

Source/Immutable/Private/Immutable/ImtblBrowserWidget.cpp

@@ -60,8 +60,9 @@ bool UImtblBrowserWidget::IsPageLoaded() const
 {
 #if USING_BUNDLED_CEF
 	return WebBrowserWidget.IsValid() && WebBrowserWidget->IsLoaded();
-#endif
+#else
 	return false;
+#endif
 }
 
 void UImtblBrowserWidget::ExecuteJS(const FString& ScriptText) const

Source/Immutable/Public/Immutable/ImmutableRequests.h

@@ -1,5 +1,6 @@
 #pragma once
 
+#include "ImmutableDataTypes.h"
 
 #include "ImmutableRequests.generated.h"
 
@@ -48,7 +49,7 @@ struct IMMUTABLE_API FImxBatchNftTransferRequest
 	GENERATED_BODY()
 
 	UPROPERTY()
-	TArray<FNftTransferDetails> nftTransferDetails;
+	TArray<struct FNftTransferDetails> nftTransferDetails;
 
 	FString ToJsonString() const;
 };

Source/Immutable/Public/Immutable/ImmutableSubsystem.h

@@ -31,16 +31,17 @@ class IMMUTABLE_API UImmutableSubsystem : public UGameInstanceSubsystem
 
 	bool IsReady() const { return bIsReady; }
 
-	// FOnGameViewportTick& OnGameViewportTick() { return GameViewportTickEvent; }
-
 	// Execute a delegate when the subsystem is ready (i.e.: when the browser is
 	// running and the Immutable SDK game bridge has loaded).
 	template <class UserClass>
 #if (ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 1)
-	void WhenReady(UserClass* Object, typename FImmutableSubsystemReadyDelegate::FDelegate::TMethodPtr<UserClass> Func);
+	void WhenReady(UserClass* Object, typename FImmutableSubsystemReadyDelegate::FDelegate::TMethodPtr<UserClass> Func)
 #else
-  void WhenReady(UserClass* Object, typename FImmutableSubsystemReadyDelegate::FDelegate::TUObjectMethodDelegate<UserClass>::FMethodPtr Func);
+  void WhenReady(UserClass* Object, typename FImmutableSubsystemReadyDelegate::FDelegate::TUObjectMethodDelegate<UserClass>::FMethodPtr Func)
 #endif
+	{
+		OnReady.AddUObject(Object, Func);
+	}
 
 private:
 	UPROPERTY()

Source/Immutable/Public/Immutable/ImtblJSMessages.h

@@ -35,7 +35,7 @@ struct IMMUTABLE_API FImtblResponseError
 	UPROPERTY()
 	FString errorMessage;
 
-	FString ToString()
+	FString ToString() const
 	{
 		const FString ErrType = StaticEnum<EImtblPassportError>()->GetNameStringByValue(static_cast<int8>(errorType));
 		return ErrType == "" ? errorMessage : ErrType + ": " + errorMessage;
@@ -110,8 +110,8 @@ struct IMMUTABLE_API FImtblJSResponse
 			FString Error;
 			if (JSResponse.JsonObject.IsValid())
 			{
-				JSResponse.JsonObject->TryGetNumberField("errorType", ErrType);
-				JSResponse.JsonObject->TryGetStringField("error", Error);
+				JSResponse.JsonObject->TryGetNumberField(TEXT("errorType"), ErrType);
+				JSResponse.JsonObject->TryGetStringField(TEXT("error"), Error);
 			}
 			JSResponse.Error = FImtblResponseError{static_cast<EImtblPassportError>(ErrType), Error};
 		}