From 61d7735bf81920ab4a98a9ae089e13d8b964ebc1 Mon Sep 17 00:00:00 2001 From: Andrew Yang Date: Fri, 11 Oct 2024 13:47:58 +1100 Subject: [PATCH] chore: pkce for webgl only --- .github/workflows/linter.yml | 2 +- sample/Assets/Scripts/SelectAuthMethodScript.cs | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index a9280ea33..b495038f7 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -57,7 +57,7 @@ jobs: VALIDATE_ALL_CODEBASE: true DEFAULT_BRANCH: main GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - FILTER_REGEX_EXCLUDE: (.*src/Packages/Passport/Runtime/ThirdParty/.*|.*src/Packages/Passport/Runtime/Resources/.*|.*Plugins/.*|.*src/Packages/Passport/Runtime/Assets/ImmutableAndroid.androidlib/.*|.*src/Packages/Orderbook|.*sample|.*src/Packages/Passport/WebGLTemplates) + FILTER_REGEX_EXCLUDE: (.*src/Packages/Passport/Runtime/ThirdParty/.*|.*src/Packages/Passport/Runtime/Resources/.*|.*Plugins/.*|.*src/Packages/Passport/Runtime/Assets/ImmutableAndroid.androidlib/.*|.*src/Packages/Orderbook|.*sample|.*src/Packages/Passport/WebGLTemplates~) VALIDATE_MARKDOWN: false VALIDATE_GITLEAKS: false VALIDATE_JSCPD: false diff --git a/sample/Assets/Scripts/SelectAuthMethodScript.cs b/sample/Assets/Scripts/SelectAuthMethodScript.cs index cf65e2e9a..e42210d87 100644 --- a/sample/Assets/Scripts/SelectAuthMethodScript.cs +++ b/sample/Assets/Scripts/SelectAuthMethodScript.cs @@ -16,14 +16,19 @@ public class SelectAuthMethodScript : MonoBehaviour void Start() { + // WebGL does not support Device Code Auth, so we'll use PKCE by default instead. +#if UNITY_WEBGL + UsePKCE(); +#else // Determine if PKCE is supported based on the platform SampleAppManager.SupportsPKCE = IsPKCESupported(); // If PKCE is not supported, initialise Passport to use Device Code Auth if (!SampleAppManager.SupportsPKCE) { - InitialisePassport(logoutRedirectUri: "https://www.immutable.com"); + UseDeviceCodeAuth(); } +#endif } ///