Remove symbols starting with 'tree_sitter_html_' #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd bugs when tree-sitter-html is used in the same program
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the file
scanner.ccfrom tree-sitter-html causes a duplication of symbols and parsing errors when using both tree-sitter-html and tree-sitter-vue in the same program. It was particularly hard to detect because there was no compiler warning in our application (Semgrep).You may not want to merge this pull request as is since the changes will be overridden when we run the script scripts/update-html-scanner.sh. I would actually suggest removing the script since it's a little complicated and keep a patch file instead. I can do this if you think it's a good idea. Let us know.
Note that I didn't invest too much time into this because recent versions of tree-sitter no longer support C++ scanners. The current scanner would have to be translated to pure C (I briefly tried and failed). tree-sitter-html was already updated to provide a C scanner.