Add edge intersection test to Contains3D #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

DmytroMuravskyi wants to merge 2 commits into hypar-io:master from DmytroMuravskyi:dmuravskyi/contains-3d

Contributor

DmytroMuravskyi commented Oct 30, 2023 •

edited by andrewheumann

Loading

BACKGROUND:

This PR fixes issue Add edge intersection test to Contains3D #767

DESCRIPTION:

Covers function already had needed logic implemented. Since the only difference between them is how they treat containment, this logic is reused for Contains3D.
Implementation of Cover is moved into shared static Contains function.

TESTING:

Added Contains3d test to PolygonTests.

FUTURE WORK:

There are inconsistency between different Covers and Contains functions described in the issue. New issue will be created to address this.

REQUIRED:

All changes are up to date in CHANGELOG.md.

This change is

DmytroMuravskyi added 2 commits

October 30, 2023 16:01


          Add edge intersection test to Contains3D

f6226bf


          Fix unit test

653f67a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet