Fix: Add JSON_UNESCAPED_UNICODE flag when encoding requests #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
PS: Payment ID created by me running the test = 3284249384 |
vikijel
changed the title
vikijel
changed the title
Author
|
@gopayprovoz Please ping the current php-sdk maintainer to check this PR, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
Prevents 403 api response due to escaped unicode chars inside the request json - by not escaping them (by adding JSON_UNESCAPED_UNICODE flag to json_encode)
Test adjusted for CZ diacritics and some special characters (we had issue with simple brackets in product names)