Error code bug in C++ when deleting an item #2
Description
After deleting successfully an item from keychain an error code is raised resulting in exception in C# code.
I run on this problem while testing the C# code on Windows.
Program.cs
using System;
namespace KeySharp
{
internal class Program
{
static void Main(string[] args)
{
Keyring.SetPassword("Lalala", "Test", "thisuser", "Neone");
try
{
var password = Keyring.GetPassword("Lalala", "Test", "thisuser");
Console.WriteLine(password);
}
catch (KeyringException ex)
{
Console.WriteLine(ex.Message);
}
Keyring.DeletePassword("Lalala", "Test", "thisuser");
}
}
}Output:
Neone
Unhandled Exception: KeySharp.KeyringException: (NoError)
at KeySharp.Keyring.ThrowLastError() in C:\Users\user\Source\Repos\KeySharp\KeySharp\Keyring.cs:line 114
at KeySharp.Keyring.DeletePassword(String package, String service, String username) in C:\Users\user\Source\Repos\KeySharp\KeySharp\Keyring.cs:line 84
at KeySharp.Program.Main(String[] args) in C:\Users\user\Source\Repos\KeySharp\KeySharp\Program.cs:line 18
The fix I am suggesting is changing the 50th line of main.cpp to if (error->type != keychain::ErrorType::NoError) similar to other functions.
I have not actually tested the change I am suggesting but I am pretty sure this is where the error occurs(I'll try to re-compile the C++ code to test it). It would be awesome if you could verify.