Fix small integer macro size, bytes not bits.

MichaelRFairhurst · MichaelRFairhurst · commit 47a6600a2f88 · 2024-10-08T22:00:36.000-07:00
diff --git a/cpp/common/src/codingstandards/cpp/IntegerConstantMacro.qll b/cpp/common/src/codingstandards/cpp/IntegerConstantMacro.qll
@@ -15,7 +15,7 @@ class IntegerConstantMacro extends Macro {
     signed = false and size = getName().regexpCapture("UINT(8|16|32|64)_C", 1).toInt()
   }
 
-  predicate isSmall() { size < any(IntType it | it.isSigned()).getSize() }
+  predicate isSmall() { size < any(IntType it | it.isSigned()).getSize() * 8 }
 
   int getSize() { result = size }
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ class IntegerConstantMacro extends Macro {`
`15`	`15`	`signed = false and size = getName().regexpCapture("UINT(8\|16\|32\|64)_C", 1).toInt()`
`16`	`16`	`}`
`17`	`17`
`18`		`- predicate isSmall() { size < any(IntType it \| it.isSigned()).getSize() }`
	`18`	`+ predicate isSmall() { size < any(IntType it \| it.isSigned()).getSize() * 8 }`
`19`	`19`
`20`	`20`	`int getSize() { result = size }`
`21`	`21`