Skip to content

Commit c4d0ba8

Browse files
authored
fix(logs): Update sentry.origin (#5112)
### Description See #4907 #### Issues Closes #4907 Closes https://linear.app/getsentry/issue/PY-1878/ensure-the-python-sdk-sets-sentryorigin-for-structured-logs-according #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
1 parent c6ad9ac commit c4d0ba8

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

sentry_sdk/integrations/logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ def _capture_log_from_record(self, client, record):
358358
project_root = client.options["project_root"]
359359

360360
attrs = self._extra_from_record(record) # type: Any
361-
attrs["sentry.origin"] = "auto.logger.log"
361+
attrs["sentry.origin"] = "auto.log.stdlib"
362362

363363
parameters_set = False
364364
if record.args is not None:

sentry_sdk/integrations/loguru.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def loguru_sentry_logs_handler(message):
167167
record["level"].no, SEVERITY_TO_OTEL_SEVERITY
168168
)
169169

170-
attrs = {"sentry.origin": "auto.logger.loguru"} # type: dict[str, Any]
170+
attrs = {"sentry.origin": "auto.log.loguru"} # type: dict[str, Any]
171171

172172
project_root = client.options["project_root"]
173173
if record.get("file"):

tests/integrations/logging/test_logging.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ def test_sentry_logs_warning(sentry_init, capture_envelopes):
320320
assert attrs["sentry.environment"] == "production"
321321
assert attrs["sentry.message.parameter.0"] == "1"
322322
assert attrs["sentry.message.parameter.1"] == "2"
323-
assert attrs["sentry.origin"] == "auto.logger.log"
323+
assert attrs["sentry.origin"] == "auto.log.stdlib"
324324
assert logs[0]["severity_number"] == 13
325325
assert logs[0]["severity_text"] == "warn"
326326

@@ -488,7 +488,7 @@ def test_logger_with_all_attributes(sentry_init, capture_envelopes):
488488
"numeric": 42,
489489
"more_complex": "{'nested': 'data'}",
490490
"logger.name": "test-logger",
491-
"sentry.origin": "auto.logger.log",
491+
"sentry.origin": "auto.log.stdlib",
492492
"sentry.message.template": "log #%d",
493493
"sentry.message.parameter.0": 1,
494494
"sentry.environment": "production",
@@ -538,7 +538,7 @@ def test_sentry_logs_named_parameters(sentry_init, capture_envelopes):
538538

539539
# Check other standard attributes
540540
assert attrs["logger.name"] == "test-logger"
541-
assert attrs["sentry.origin"] == "auto.logger.log"
541+
assert attrs["sentry.origin"] == "auto.log.stdlib"
542542
assert logs[0]["severity_number"] == 9 # info level
543543
assert logs[0]["severity_text"] == "info"
544544

tests/integrations/loguru/test_loguru.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def test_sentry_logs_warning(
154154
assert "code.line.number" in attrs
155155
assert attrs["logger.name"] == "tests.integrations.loguru.test_loguru"
156156
assert attrs["sentry.environment"] == "production"
157-
assert attrs["sentry.origin"] == "auto.logger.loguru"
157+
assert attrs["sentry.origin"] == "auto.log.loguru"
158158
assert logs[0]["severity_number"] == 13
159159
assert logs[0]["severity_text"] == "warn"
160160

@@ -465,7 +465,7 @@ def test_logger_with_all_attributes(
465465
# Assert on the remaining non-dynamic attributes.
466466
assert attributes == {
467467
"logger.name": "tests.integrations.loguru.test_loguru",
468-
"sentry.origin": "auto.logger.loguru",
468+
"sentry.origin": "auto.log.loguru",
469469
"sentry.environment": "production",
470470
"sentry.sdk.version": VERSION,
471471
"sentry.severity_number": 13,

0 commit comments

Comments
 (0)