Skip to content

Commit d52ed58

Browse files
chore(proguard): Remove --android-manifest argument (#2940)
### Description This argument does not do anything, so we will remove it. ### Issues - Resolves #2874 - Resolves [CLI-200](https://linear.app/getsentry/issue/CLI-200/remove-upload-proguards-android-manifest-argument)
1 parent ac20051 commit d52ed58

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ we should rename this section to "Unreleased" -->
1717
- `SENTRY_API_KEY` environment variable
1818
- `api_key` configuration file field
1919
- `apiKey` option in the JavaScript API
20-
- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, and `--version-code` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.
20+
- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, `--version-code`, and `--android-manifest` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876), [#2940](https://github.com/getsentry/sentry-cli/pull/2940)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.
2121

2222
### Improvements
2323

src/commands/upload_proguard.rs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,6 @@ pub fn make_command(command: Command) -> Command {
4949
proguard UUIDs into a properties file.",
5050
),
5151
)
52-
.arg(
53-
Arg::new("android_manifest")
54-
.long("android-manifest")
55-
.value_name("PATH")
56-
.hide(true)
57-
.help(
58-
"[DEPRECATED] This flag is a no-op, scheduled \
59-
for removal in Sentry CLI 3.0.0.",
60-
),
61-
)
6252
.arg(
6353
Arg::new("write_properties")
6454
.long("write-properties")
@@ -100,14 +90,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
10090
);
10191
}
10292

103-
if matches.get_one::<String>("android_manifest").is_some() {
104-
log::warn!(
105-
"[DEPRECATION NOTICE] The --android-manifest argument is deprecated, \
106-
and is scheduled for removal in Sentry CLI 3.0.0. \
107-
The argument is a no-op."
108-
);
109-
}
110-
11193
let paths: Vec<_> = match matches.get_many::<String>("paths") {
11294
Some(paths) => paths.collect(),
11395
None => {

0 commit comments

Comments
 (0)