add join() posix throughout

Author: scivision

+stdlib/+fileio/absolute_path.m

@@ -18,9 +18,9 @@
 
 if ~stdlib.fileio.is_absolute_path(abspath)
   % .toAbsolutePath() default is Documents/Matlab, which is probably not wanted.
-  abspath = fullfile(pwd, abspath);
+  abspath = stdlib.fileio.join(pwd, abspath);
 end
 
-abspath = string(java.io.File(abspath).getAbsolutePath());
+abspath = stdlib.posix(java.io.File(abspath).getAbsolutePath());
 
 end % function

+stdlib/+fileio/canonical.m

@@ -19,7 +19,7 @@
 if ~stdlib.fileio.is_absolute_path(c)
   if isfile(c) || isfolder(c)
     % workaround Java/Matlab limitations
-    c = fullfile(pwd, c);
+    c = stdlib.fileio.join(pwd, c);
   else
     % for non-existing path, return normalized relative path
     % like C++ filesystem weakly_canonical()

+stdlib/+fileio/expanduser.m

@@ -13,7 +13,7 @@
 home = stdlib.fileio.homedir();
 
 if ~isempty(home)
-  e = fullfile(home, extractAfter(e, 1));
+  e = stdlib.fileio.join(home, extractAfter(e, 1));
 end
 
 end %function

+stdlib/+fileio/join.m

@@ -0,0 +1,10 @@
+function p = join(a, b)
+%% JOIN: join two paths with posix file separator
+arguments
+  a string {mustBeScalarOrEmpty}
+  b string {mustBeScalarOrEmpty}
+end
+
+p = stdlib.fileio.posix(fullfile(a, b));
+
+end

+stdlib/+fileio/posix.m

@@ -1,14 +1,11 @@
-function ppath = posix(file)
+function p = posix(p)
 
 arguments
-  file string
+  p string
 end
 
-
-ppath = fullfile(file);
-
 if ispc
-  ppath = strrep(ppath, "\", "/");
+  p = strrep(p, "\", "/");
 end
 
 end

+stdlib/+fileio/resolve.m

@@ -19,7 +19,7 @@
 
 if ~stdlib.fileio.is_absolute_path(c)
   % .toAbsolutePath() default is Documents/Matlab, which is probably not wanted.
-  c = fullfile(pwd, c);
+  c = stdlib.fileio.join(pwd, c);
 end
 
 % similar benchmark time as java method

+stdlib/+fileio/which.m

@@ -41,7 +41,7 @@
 for name = names
 
   for p = fpath
-    exe = fullfile(p, name);
+    exe = stdlib.fileio.join(p, name);
     if stdlib.fileio.is_exe(exe)
       return
     end

+stdlib/+fileio/with_suffix.m

@@ -1,13 +1,13 @@
 function filename = with_suffix(filename, suffix)
 
 arguments
-  filename string
+  filename string {mustBeScalarOrEmpty}
   suffix (1,1) string
 end
 
 [direc, name, ext] = fileparts(filename);
 if ext ~= suffix
-  filename = fullfile(direc, name + suffix);
+  filename = stdlib.fileio.join(direc, name + suffix);
 end
 
 end

+stdlib/join.m

@@ -0,0 +1,10 @@
+function p = join(a, b)
+%% JOIN: join two paths with posix file separator
+arguments
+  a string {mustBeScalarOrEmpty}
+  b string {mustBeScalarOrEmpty}
+end
+
+p = stdlib.fileio.join(a, b);
+
+end

test/TestFileImpure.m

@@ -25,7 +25,7 @@ function test_expanduser(tc)
 tc.verifyEqual(stdlib.expanduser("~"), h)
 
 e = stdlib.expanduser("~/foo");
-tc.verifyEqual(e, stdlib.posix(fullfile(h, "foo")))
+tc.verifyEqual(e, stdlib.fileio.join(h, "foo"))
 
 end
 
@@ -54,8 +54,7 @@ function test_canonical(tc)
 
 % test existing file
 r = stdlib.parent(mfilename('fullpath'));
-rp = fullfile(r, "..");
-tc.verifyEqual(stdlib.canonical(rp), stdlib.parent(r))
+tc.verifyEqual(stdlib.canonical(fullfile(r, "..")), stdlib.parent(r))
 
 h = stdlib.fileio.homedir;
 tc.verifyEqual(stdlib.canonical("~"), h)
@@ -105,16 +104,16 @@ function test_resolve(tc)
 
 % test existing file
 r = stdlib.parent(mfilename('fullpath'));
-rp = fullfile(r, "..");
+rp = stdlib.parent(r);
 tc.verifyEqual(stdlib.resolve(rp), stdlib.parent(r))
 
 h = stdlib.fileio.homedir;
 tc.verifyEqual(stdlib.resolve("~"), h)
 tc.verifyEqual(stdlib.resolve("~/"), h)
 tc.verifyEqual(stdlib.resolve("~/.."), stdlib.parent(h))
 
-tc.verifyEqual(stdlib.resolve("nobody.txt"), fullfile(td, "nobody.txt"))
-tc.verifyEqual(stdlib.resolve("../nobody.txt"), fullfile(stdlib.parent(td), "nobody.txt"))
+tc.verifyEqual(stdlib.resolve("nobody.txt"), stdlib.join(td, "nobody.txt"))
+tc.verifyEqual(stdlib.resolve("../nobody.txt"), stdlib.join(stdlib.parent(td), "nobody.txt"))
 
 end