bottle song #1583
bottle song #1583
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
SleeplessByte
left a comment
SleeplessByte
left a comment
There was a problem hiding this comment.
This is missing the deprecation of beer-song (if relevant) in config.json and addition of bottle-song. Without that change, this exercise replacement will not show up on exercism.org
|
@SleeplessByte config.json is updated. This is my first attempt at adding an exercise to Exercism, so if I'm missing something obvious please let me know! I haven't seen anything about beer song being deprecated on the TypeScript build page, and I've seen beer song and bottle song live in harmony, so I'm not sure if it is relevant to this track. If I'm wrong, please let me know what changes are needed. Thank you for your time! |
|
@SleeplessByte Just checking to see if there's anything I need to do for this. |
|
@Budmin sorry, this got snowed under in my notifications. Yes, the idea is that if we add bottle song, we remove beer song, because it's the same exercise! |
|
@SleeplessByte no worries. I've set the status of beer song to deprecated. Thanks again |
2 participants
No description provided.