@@ -40,45 +40,45 @@ Changes since v1:
4040| | | These are my notes from the chat:
4141| | |
4242| | | - When there is a change with DRM leases, a normal DRM hotplug event
43- | | | will be emitted.
43+ | | | will be emitted.
4444| | |
4545| | | - Particularly Lessor needs to listen for hotplug events and re-query
46- | | | the state of all DRM leases. This is how Lessor finds out a lease has
47- | | | been terminated by a Lessee. This needs to happen also on gaining DRM
48- | | | master.
46+ | | | the state of all DRM leases. This is how Lessor finds out a lease has
47+ | | | been terminated by a Lessee. This needs to happen also on gaining DRM
48+ | | | master.
4949| | |
5050| | | - VT-switching: When the original DRM master (Lessor) drops the master
51- | | | status, all DRM leases it has given out will be temporarily disabled.
52- | | | When Lessor regains DRM master, the disabled leases are automatically
53- | | | reinstated.
51+ | | | status, all DRM leases it has given out will be temporarily disabled.
52+ | | | When Lessor regains DRM master, the disabled leases are automatically
53+ | | | reinstated.
5454| | |
5555| | | - Lessee can tell the difference between a permanent revoke and a
56- | | | temporary disable of a lease by the error it gets from the KMS API
57- | | | (drmModeSetCrtc, drmModePageFlip, drmModeAtomicCommit): EACCESS for
58- | | | temporary disable, and ENOENT for a revoked lease that is not coming
59- | | | back.
56+ | | | temporary disable of a lease by the error it gets from the KMS API
57+ | | | (drmModeSetCrtc, drmModePageFlip, drmModeAtomicCommit): EACCESS for
58+ | | | temporary disable, and ENOENT for a revoked lease that is not coming
59+ | | | back.
6060| | |
6161| | | - If Lessee gets EACCESS, it should stand by and wait for hotplug
62- | | | events to try again with the hope that the lease comes back.
62+ | | | events to try again with the hope that the lease comes back.
6363| | |
6464| | |
6565| | | Some random thoughts from me:
6666| | |
6767| | | - Need to make sure the client has enough information to listen for
68- | | | hotplug events in a multi-card system.
68+ | | | hotplug events in a multi-card system.
6969| | |
7070| | | - If the Wayland client disconnects, revoke all its leases.
71- | | | Implementation-wise this is easy as the wl_resource gets
72- | | | destroyed.
71+ | | | Implementation-wise this is easy as the wl_resource gets
72+ | | | destroyed.
7373| | |
7474| | | - We probably do not want a Wayland event for compositor dropping DRM
75- | | | master, because it would be racy in the client against KMS calls and
76- | | | the client will notice on its own anyway.
75+ | | | master, because it would be racy in the client against KMS calls and
76+ | | | the client will notice on its own anyway.
7777| | |
7878| | | - There could be a Wayland event for compositor gaining DRM master, to
79- | | | tell the client to try KMS again now, but it seems redundant: the DRM
80- | | | hotplug event provides the same, and needs to be listened to anyway
81- | | | if the client wants to react to hotplug on its leased connector.
79+ | | | tell the client to try KMS again now, but it seems redundant: the DRM
80+ | | | hotplug event provides the same, and needs to be listened to anyway
81+ | | | if the client wants to react to hotplug on its leased connector.
8282
8383diff --git a/Makefile.am b/Makefile.am
8484index 4b9a901..4f6a874 100644
@@ -183,7 +183,7 @@ index 0000000..907efb0
183183+ Destroys the lease manager object.
184184[inline thread by ppaalanen at gmail.com (Pekka Paalanen) at Tue, 29 May 2018 17:10:02 +0300]
185185| + This has no effect on any remaining objects created through this
186- | interface.
186+ | interface.
187187+ </description>
188188+ </request>
189189+
@@ -481,7 +481,7 @@ index 0000000..907efb0
481481+ This event indicates that the lease could not be created/revoked.
482482[inline thread by ppaalanen at gmail.com (Pekka Paalanen) at Tue, 29 May 2018 17:10:02 +0300]
483483| + The client should destroy this object, and possibly try again with a
484- | different set of DRM resources.
484+ | different set of DRM resources.
485485+ </description>
486486+ </event>
487487[inline thread by ppaalanen at gmail.com (Pekka Paalanen) at Tue, 29 May 2018 17:10:02 +0300]
0 commit comments