[FIX] sanitize GitHub repo names to prevent space-to-dash mismatch

[akash1520]

Fixes issue where GitHub automatically converts spaces to dashes in repo names but Dyad continued referencing the original names with spaces, causing connection and push failures.

---

Summary by cubic

Sanitizes GitHub repo and local app folder names (spaces → dashes) to match GitHub behavior. Fixes failures when creating, connecting, or pushing to repos with spaces.

• Bug Fixes
  • Added sanitizeAppFolderName and ensureAppFolderSanitized to rename folders, update DB (path/githubRepo), and guard against conflicts.
  • Create repo: always uses sanitized folder name; stores sanitized repo; repo param is now optional.
  • Connect existing: sanitizes repo before lookup and save; clearer error includes attempted sanitized name.
  • Push: sanitizes folder first; normalizes and persists githubRepo before building the remote URL.
  • Updated IPC handler typing for github:create-repo.

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="src/ipc/handlers/github_handlers.ts">

<violation number="1" location="src/ipc/handlers/github_handlers.ts:495">
Remove unused repo from args type; it’s not used by handleCreateRepo and can confuse callers.</violation>
</file>

---

Since this is your first cubic review, here's how it works:

• cubic automatically reviews your code and comments on bugs and improvements
• Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
• Ask questions if you need clarification on any suggestion

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[wwwillchen]

thanks for the PR. this fix feels a bit heavy-handed as it's actually renaming the folder as part of the git sync (which seems quite surprising from a user perspective). I don't think we need to rename the app folder (IIUC) to fix this issue.

Also, let's add an e2e test https://github.com/dyad-sh/dyad/blob/main/CONTRIBUTING.md#e2e-tests - probably add a test case here: https://github.com/dyad-sh/dyad/blob/main/e2e-tests/github.spec.ts

[akash1520]

thanks for the PR. this fix feels a bit heavy-handed as it's actually renaming the folder as part of the git sync (which seems quite surprising from a user perspective). I don't think we need to rename the app folder (IIUC) to fix this issue.

Also, let's add an e2e test https://github.com/dyad-sh/dyad/blob/main/CONTRIBUTING.md#e2e-tests - probably add a test case here: https://github.com/dyad-sh/dyad/blob/main/e2e-tests/github.spec.ts

@wwwillchen Got rid of folder renaming, plus added an e2e test.