can't set storage_class to inherit the source object in replication rules

[NoaBM]

Describe the Bug

When creating s3 bucket with s3_replication_rules, the storage_class inside destination is always enabled as "STANDARD" and can't be set to null, when the null should use the source replication bucket.

Expected Behavior

storage_class for replication should not be set, and should be taken from the source replication bucket.

Steps to Reproduce

call the module with all relevant fields including the replication fields -

module "s3_bucket" {
    source                  = "cloudposse/s3-bucket/aws"
    version                 = "4.0.1"
    s3_replication_rules = [{
         destination = {
              storage_class = null
          }
     }]
}

see in aws console that the "Destination storage class" is set to Standard and not as it should be unmarked.

Screenshots

No response

Environment

• Terraform version - 1.5
• module version - 4.0.1

Additional Context

I tested a fix to the module in variables.tf line 267 and changed it to - storage_class = optional(string, null), and it seems to work either if :

• we don't send "storage_class" to the module at all, the result is inherited from the source bucket

• we do send "storage_class = STANDARD" it's sets it to standard.

[nitrocode]

Seems like this is functioning as per the terraform docs

https://developer.hashicorp.com/terraform/language/expressions/type-constraints

There doesn't seem to be a way to explicitly set the nested key to null without it getting replaced with the default value

terraform-aws-s3-bucket/variables.tf

Line 252 in 424de84

variable "s3_replication_rules" {

terraform-aws-s3-bucket/variables.tf

Lines 271 to 273 in 424de84

	destination = object({
	bucket = optional(string) # destination bucket ARN, overrides s3_replica_bucket_arn
	storage_class = optional(string, "STANDARD")

So you're right, we can either

1. change the default to null (breaking change)
2. remove the default (breaking change)
3. Add a separate input to the map e.g. s3_replication_rules.storage_class_inherit_enabled and if true, set the argument to null
4. Add a completely separate input e.g. var.s3_replica_storage_class_inherit_enabled
5. Allow an empty string in storage_class to get converted to null

I'm leaning more towards 3. What do you think?