Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,12 @@ try {
*/
if (argv.report.includes('text')) {
const data = [];
data.push(['File', '% Stmt', '% Branch', 'Uncovered Line #s', 'Lines Changed']);
data.push(['File', '% Stmt', '% Branch', 'Uncovered Line #s', 'Uncovered Branch Line #s', 'Lines Changed']);
data.push(['All changed files',
getColorMessage(totalStmtPercentage, `${totalStmtPercentage}%`),
getColorMessage(totalBranchPercentage, `${totalBranchPercentage}%`),
'',
'',
'']);

_.forEach(diffCodeCoverage, (value, key) => {
Expand All @@ -140,6 +141,7 @@ try {
getColorMessage(stmtPercentage, `${stmtPercentage}%`),
getColorMessage(branchPercentage, `${branchPercentage}%`),
value.stmt.unCoveredLines.toString(),
value.branch.unCoveredLines.toString(),
value.lines]);
});
const options = {
Expand Down
6 changes: 6 additions & 0 deletions coverageOnDiff.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,19 +98,25 @@ function changedBranchCoverage(coverage, changedLines) {

let nCovered = 0;
let nUncovered = 0;
const changedCoveredLines = [];
const unchangedCoveredLines = [];

for (const line of changedLines) {
if (coveredLines.includes(line)) {
changedCoveredLines.push(line);
nCovered++;
}
if (uncoveredLines.includes(line)) {
unchangedCoveredLines.push(line);
nUncovered++;
}
}

return {
nCovered,
nUncovered,
coveredLines: changedCoveredLines,
unCoveredLines: unchangedCoveredLines,
};
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "coverage-on-diff",
"version": "0.0.3",
"version": "0.0.4",
"description": "A tool to get code coverage on new lines added based on a diff",
"main": "index.js",
"scripts": {
Expand Down
8 changes: 8 additions & 0 deletions test/testCoverageOnDiff.js
Original file line number Diff line number Diff line change
Expand Up @@ -174,27 +174,35 @@ describe('CoverageOnDiff Test', () => {
result.should.eql({
nCovered: 0,
nUncovered: 0,
coveredLines: [],
unCoveredLines: [],
});
});
it('should have covered branch changes', () => {
const result = changedBranchCoverage(dataFactory.getParsedCodeCoverage()['dummy/dummyUtil.js'], dataFactory.getGoodChangedStmt());
result.should.eql({
nCovered: 1,
nUncovered: 0,
coveredLines: [10],
unCoveredLines: [],
});
});
it('should have uncovered branch changes', () => {
const result = changedBranchCoverage(dataFactory.getParsedCodeCoverage()['dummy/dummyUtil.js'], dataFactory.getBadChangedStmt());
result.should.eql({
nCovered: 0,
nUncovered: 1,
coveredLines: [],
unCoveredLines: [15],
});
});
it('should be uncovered branch when there is at least 1 uncovered path', () => {
const result = changedBranchCoverage(dataFactory.getParsedCodeCoverage()['dummy/dummyUtil.js'], dataFactory.getBadChangedStmtBranch());
result.should.eql({
nCovered: 0,
nUncovered: 1,
coveredLines: [],
unCoveredLines: [30],
});
});
});
Expand Down