"Introduced by" is unstable, reverts to latest speaker in group chat and changes all the time

[ell1e]

It seems like in the latest core shipped with desktop the "Introduced by" info in the profile is unstable. It reverts to latest speaker in group chat and changes all the time. This is a problem most prominently for contacts who I scanned directly at some point, for whom it also has reverted to "Introduced by", hence hiding the previously acquired direct trust info for the user.

• Operating System (Linux/Mac/Windows/iOS/Android): Linux
• Core Version: 2.11.1 (git: flathub)
• Client Version: desktop 2.11.1 (git: flathub)

Expected behavior

"Introduced by" is stable, and if I scan a person directly it shows myself and doesn't revert to a third party.

Actual behavior

"Introduced by" is unstable, reverting both from me to third parties, and also in between multiple third parties as new messages comes in.

Steps to reproduce the problem

1. Check "Introduced by" regularly and see it change

Screenshots

Logs

[iequidoo]

Closing as fixed by 7e4822c which is in 2.12.
There are more verification fixes in 2.13, so it's better to test this functionality at least in this release. DC Desktop is 2.15 already, so the bugfix can be checked there.

[ell1e]

@iequidoo the desktop flatpak still seems to be at 2.11.

[ell1e]

This still seems to be broken in 2.22 under some circumstances. E.g. somebody just added a ton of people to a group somehow, not sure if old state, but now everybody including those who were already in there is shown as introduced by that person.

[iequidoo]

I don't think it depends on the number of members added, it'd interesting to know what happens if somebody else adds a new member to the group i.e. if other existing members will be "introduced by" that somebody.

[ell1e]

I've been trying to figure out how exactly this happened, but haven't tracked it down yet.

However, it would be nice if the "Introduced by" would be way more stable than it is. If I scan in person but the "Introduced by" changes later, it makes the entire trust system kind of impossible to check on as a user. Ideally it should just never change, unless the trust level is increased. Sadly, this doesn't seem to work yet.

[Simon-Laux]

#7336

Removed a migration that seems to have reset the verifier, maybe loosely related, I don't know the code for verification well enough yet to tell.

[iequidoo]

Neither 19d7799 nor 2481a0f are in 2.22, so they aren't relevant.

I'm adding a new test in #7145 for a couple of bugs we had before.

If I scan in person but the "Introduced by" changes later, it makes the entire trust system kind of impossible to check on as a user. Ideally it should just never change, unless the trust level is increased.

This was fixed in 7e4822c and a test added. If we still have some bug here, we need a way to reproduce it, just looking at the code i don't see anything suspicious.