-
Notifications
You must be signed in to change notification settings - Fork 12
bumps tools to latest versions #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This looks good to me. We can merge this and follouw up on |
|
Sounds good. |
|
Should NativeAOT-LLVM also be bumped? In bytecodealliance/wit-bindgen the CI is running WASI SDK 27 + the latest version of NativeAOT-LLVM (there is no fixed version). WASI SDK 27 is tested with this version. I'm not sure if the current version ( The latest version can be checked here: https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-experimental/NuGet/Microsoft.DotNet.ILCompiler.LLVM |
|
Ah... It seems like the target Because of this, the WASI SDK isn't being set anymore ( componentize-dotnet/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets Lines 23 to 27 in b132a2a
Maybe this needs to be renamed to /cc @SingleAccretion |
All of these targets are internal implementation details of the NAOT-LLVM build packaging. I would recommend sequencing before a more public target. For example, |
Narrows version parsing to the intended SDK dependency to avoid grabbing unrelated Version attributes and causing false mismatch failures in the CI version check. Improves reliability of the template/package version comparison.
|
Thanks @GerardSmit & @SingleAccretion ! I updated to use What is the usual way to test these artifacts? In the build, I saw: For my future reference, the targets are here: |
This is what I did to test locally (I copied the *.nupkg files in the I think you can also use the example project componentize-dotnet/samples/calculator/Adder/Adder.csproj Lines 3 to 4 in b132a2a
|
|
Just learned about the https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-nuget-registry , so I pushed it there.
To add: dotnet nuget add source --username $env.GH_USER --password $env.GH_TOKEN --store-password-in-clear-text --name cataggar "https://nuget.pkg.github.com/cataggar/index.json" |
|
My test project now compiles successfully with: <PackageReference Include="BytecodeAlliance.Componentize.DotNet.Wasm.SDK" Version="0.7.0-preview00207" />
<PackageVersion Include="Microsoft.DotNet.ILCompiler.LLVM" Version="10.0.0-preview.2.25455.1" />
<PackageReference Include="runtime.win-x64.microsoft.dotnet.ilcompiler.llvm" Version="10.0.0-preview.2.25455.1" /> |
|
I moved this to draft after trying it out in Visual Studio Code and Visual Studio. In either, it constantly deletes and regenates the files every few seconds. You can see it when you enable this: <WitGeneratedFilesRoot>generated/wit</WitGeneratedFilesRoot> |
You can either download these packages from the PR or I typically create the packages locally ( Thanks for working on getting this all updated! |
I'm using this project only with just AI coding and without editor support. The editor support has problems for this PR, but also on main. I think this pull request is ready to merge. |
Ok so this was happening prior to this? I use VS Code but hadn't noticed it. If so, Will create an issue and we can move forward here. Thanks! |
|
Yes, that is what I observed. On |
|
Honestly, I'm not sure about what the compatibility is supposed to be between some of these. May be @GerardSmit knows. #99 looks like it may help. |
|
I'm not sure. Personally I'm using Rider, not VS or VS Code and I haven't had this issue. In PR #99 I only changed the "BytecodeAlliance.Componentize.DotNet.Wasm.SDK" to a NuGet SDK project. It seems this problem is coming from "BytecodeAlliance.Componentize.DotNet.WitBindgen". So, I don't think this PR will help. From what I can see; the directory is being removed but instantly after that the wit-bindgen is executed: componentize-dotnet/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets Lines 93 to 95 in b132a2a
This is executed on componentize-dotnet/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets Lines 51 to 53 in b132a2a
I'm not sure when Visual Studio executes this task. Googling and ChatGPT'ing also doesn't answer this question;
The only thing I can think of, is that BeforeCompile gets executed, WitBindgen generates the code, Visual Studio sees that the .cs-files are changed and compiles again, causing BeforeCompile to be fired again. However, this is a speculation since I don't have this issue. |



No description provided.