Feat/automatic update installation #5345

AdemolaAri · 2025-10-23T22:28:01Z

Summary

This is a feature request (#4322) to have goose auto-download and install updates when available. This change adds that functionality.

Type of Change

Testing

Manual testing of the actual build. I added console.log statements and followed the follwing steps

Build the app. cd ui/desktop / npm run package / npm run make
Open the executable file and saw updates auto-downloaded to download folder
confirmed the right releases was auto-downloaded (tested on Mac only)

Note: because these builds are unsigned, i wasn't able to test the auto-install part. I believe that should work as well.

Related Issues

Relates to #ISSUE_ID
Discussion: LINK (if any)

#4322

Screenshots/Demos (for UX changes)

Before:

After:

|
|

|
|

Email:

AdemolaAri · 2025-10-23T22:29:03Z

ui/desktop/src/components/settings/app/UpdateSection.tsx

-  const downloadAndInstallUpdate = async () => {
-    setUpdateStatus('downloading');
-    setProgress(0);
-
-    try {
-      const result = await window.electron.downloadUpdate();
-
-      if (!result.success) {
-        throw new Error(result.error || 'Failed to download update');
-      }
-
-      // The download progress and completion will be handled by updater events
-    } catch (error) {
-      console.error('Error downloading update:', error);
-      setUpdateInfo((prev) => ({
-        ...prev,
-        error: error instanceof Error ? error.message : 'Failed to download update',
-      }));
-      setUpdateStatus('error');
-      setTimeout(() => setUpdateStatus('idle'), 5000);
-    }
-  };
-


removed as downloads are automatic now

AdemolaAri · 2025-10-23T22:29:41Z

ui/desktop/src/components/settings/app/UpdateSection.tsx

+        {updateInfo.isUpdateAvailable && updateStatus === 'idle' && (
+          <div className="text-xs text-text-muted mt-4 space-y-1">
+            <p>Update will be downloaded automatically in the background.</p>
+            <p className="text-xs text-green-600">
+              The update will be installed automatically when you quit the app.
+            </p>
+          </div>
+        )}
+


expected behavior for signed build

AdemolaAri · 2025-10-23T22:31:24Z

ui/desktop/src/utils/githubUpdater.ts

      log.info(`GitHubUpdater: Available assets: ${release.assets.map((a) => a.name).join(', ')}`);

-      const asset = release.assets.find((a) => a.name === assetName);
+      const asset = release.assets.find((a) => a.name.toLowerCase() === assetName); // keeping comparisms to lower case becasue Goose vs goose


thought about either changing the hardcoded values in lines 94-103 or keeping this normalized comparison. Let me know if i should change the hardcoded values instead.

AdemolaAri · 2025-10-23T22:32:21Z

ui/desktop/src/utils/githubUpdater.ts

        log.warn(`GitHubUpdater: No matching asset found for ${assetName}`);
      }

+      if (!downloadUrl) {


edge case - update is available but no asset match.
TLDR; App detects there is a new version to be downloaded, code block on line 94 assetName = 'goose.zip'; but the build for that platform has Goose.zip. Due to uppercase - lowercase 'G' no downloadUrl set and downloading a new version keeps failing cause no url to hit.

Signed-off-by: AdemolaAri <ademola.ari@gmail.com>

…logic Signed-off-by: AdemolaAri <ademola.ari@gmail.com>

Signed-off-by: AdemolaAri <ademola.ari@gmail.com>

taniandjerry · 2025-10-24T20:35:24Z

Thank you for your contribution! Let me add the tags, and tag teammates for review.

@DOsinga @alexhancock @michaelneale @jamadeo @zanesq @angelahning

As we are in the weekend in AU and in the states, expect a review come Monday, ET! @AdemolaAri

zanesq · 2025-10-27T23:49:44Z

Thanks @AdemolaAri! I tested locally and it seems to download the update but it didn't actually install it after restart does it work for you?

Also a few minor things with the experience:

This existed already but the tray icon has a dot that an update is available but when clicking it just opens settings, can you fix that so it opens the app tab in settings?

2. The prompt after downloading still shows the text to the user to extract the file and move to Applications. After clicking this it open downloads it closes the app. Can we improve this experience a bit?

AdemolaAri · 2025-10-28T01:07:01Z

@zanesq , auto-install did not work for me on mac. from my findings, it seems Mac does not allow auto-install of unsigned app which is what builds locally. to really test auto-install, we'll need a signed app - which I believe only the app owners can do. chatGPT breakdown and references to this (https://chatgpt.com/share/690015a1-9500-800a-96a9-830079e13087)

I'll work on those other items.

zanesq · 2025-10-28T15:44:03Z

.bundle

zanesq · 2025-10-28T23:17:35Z

ok thanks looking into how we can test a signed version of this.. also if you want to look at #5424 while you are at it

taniandjerry · 2025-10-29T19:11:11Z

quick heads up timing wise! @zanesq - Hacktoberfest has a deadline where all PRs need to be merged by October 31st (Friday). To make sure contributor PRs like this one hit that deadline on time, aiming to have these PRs reviewed and approved (if we're able) by EOD tomorrow (October 30th)! Let me know if you think it's possible for this one 🙏 and thank you for working on this, @AdemolaAri !

zanesq · 2025-10-29T19:16:00Z

Not sure if this will make it unfortunately since there are still changes requested and we need to test in an actual signed release. I'll try to get a signed release tested with the current changes so we can rule that out at least.

zanesq · 2025-10-29T20:20:56Z

after the requested changes are made and approved if this doesn't break anything we can merge to main to test on a signed build and revert if needed

AdemolaAri · 2025-10-29T21:04:41Z

@taniandjerry , I'm sorry I've not been able to work on the other things I need for this - I do not have access to my computer until this Friday. It's fine if this doesn't count towards HacktoberFest. I plan to get the updates on this PR out sometime this weekend

taniandjerry · 2025-10-29T21:28:24Z

@taniandjerry , I'm sorry I've not been able to work on the other things I need for this - I do not have access to my computer until this Friday. It's fine if this doesn't count towards HacktoberFest. I plan to get the updates on this PR out sometime this weekend

That is amazing. Since your submission would likely pass beyond hacktoberfest, but you've been working on this feature with @zanesq that will make an impact on users for goose, I'll definitely be sure we are able to reward you in some way for still working on this. 🤗 ❤️ looking forward to getting this across the finish line!

zanesq · 2025-10-29T23:21:38Z

@michaelneale made a signed build to test from this branch but I get the following error message Update Available but no download URL found for platform: darwin, arch: arm64 does that happen for you?

AdemolaAri · 2025-10-30T02:16:36Z

@michaelneale made a signed build to test from this branch but I get the following error message Update Available but no download URL found for platform: darwin, arch: arm64 does that happen for you?

@zanesq interesting. I believe you're hitting this code block, I added https://github.com/block/goose/pull/5345/files#r2457676532 . I encountered this when the app detects that there's a new version available, but when the code scans the release version repository it couldn't find a build for that assetName. Yeah, I thought I resolved it by making the assetName search case insensitive but might need some cleanups there

zanesq · 2025-10-30T15:51:44Z

not latest version its 1.11.0 in the screenshot and latest is 1.12.1

AdemolaAri commented Oct 23, 2025

View reviewed changes

AdemolaAri added 3 commits October 23, 2025 17:36

fix: ensure asset name comparison is case-insensitive in GitHubUpdater

c92720a

Signed-off-by: AdemolaAri <ademola.ari@gmail.com>

feat: enable automatic updates and add GitHub fallback auto-download …

1ff4842

…logic Signed-off-by: AdemolaAri <ademola.ari@gmail.com>

refactor: remove manual download and installation process for updates

ddccbb6

Signed-off-by: AdemolaAri <ademola.ari@gmail.com>

AdemolaAri force-pushed the feat/AutomaticUpdateInstallation branch from bdab6cc to ddccbb6 Compare October 23, 2025 22:36

taniandjerry requested review from a team, DOsinga, alexhancock and zanesq October 24, 2025 20:35

taniandjerry assigned AdemolaAri Oct 24, 2025

taniandjerry added hacktoberfest Issues awarding points for Hacktoberfest 2025! large Weight label for Hacktoberfest 2025 issues labels Oct 24, 2025

Feat/automatic update installation #5345

Are you sure you want to change the base?

Feat/automatic update installation #5345

Uh oh!

Conversation

AdemolaAri commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Related Issues

Screenshots/Demos (for UX changes)

Uh oh!

AdemolaAri Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

AdemolaAri Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

AdemolaAri Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

AdemolaAri Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taniandjerry commented Oct 24, 2025

Uh oh!

zanesq commented Oct 27, 2025

Uh oh!

AdemolaAri commented Oct 28, 2025

Uh oh!

zanesq commented Oct 28, 2025

Uh oh!

zanesq commented Oct 28, 2025

Uh oh!

taniandjerry commented Oct 29, 2025

Uh oh!

zanesq commented Oct 29, 2025

Uh oh!

zanesq commented Oct 29, 2025

Uh oh!

AdemolaAri commented Oct 29, 2025

Uh oh!

taniandjerry commented Oct 29, 2025

Uh oh!

zanesq commented Oct 29, 2025

Uh oh!

AdemolaAri commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zanesq commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AdemolaAri commented Oct 23, 2025 •

edited

Loading

AdemolaAri Oct 23, 2025 •

edited

Loading

AdemolaAri commented Oct 30, 2025 •

edited

Loading