add footer to command-pal with configurable text #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New CommandPal option footerText. If set to null (default) no
footer is displayed. If set to a string the string is displayed.
The way I handle conditionally showing the footer is kind of ugly.
Svelte doesn't have conditional slots. Once:
sveltejs/svelte#5604
is implemented, the whole mess can be cleanly rewritten.
I would have like to use :where(.footer) in the css for styling. But
there are a lot of mobile browsers on caniuse that have unknown status
even 2 years after their release.
Using :where would allow ".footer" in user's css to work. As it is
you have to make ".footer" more specific using e.g. "#id .footer" or
".footer[slot=footer]".
README.md, and cp-advanced files updated to show/use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CommandPal option footerText. If set to null (default) no footer is displayed. If set to a string the string is displayed.
The way I handle conditionally showing the footer is kind of ugly. Svelte doesn't have conditional slots. Once:
is implemented, the whole mess can be cleanly rewritten.
I would have like to use :where(.footer) in the css for styling. But there are a lot of mobile browsers on caniuse that have unknown status even 2 years after their release.
Using :where would allow ".footer" in user's css to work. As it is you have to make ".footer" more specific using e.g. "#id .footer" or ".footer[slot=footer]".
README.md, and cp-advanced files updated to show/use.