From 2e31209525a026b1533e273bf5f4cbe2653c2515 Mon Sep 17 00:00:00 2001 From: mailtokartik1 Date: Wed, 31 Jul 2019 16:24:22 +0900 Subject: [PATCH 1/3] change bloom filter export set --- BloomFilterWrap.cpp | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/BloomFilterWrap.cpp b/BloomFilterWrap.cpp index 16a7b59..e382b53 100644 --- a/BloomFilterWrap.cpp +++ b/BloomFilterWrap.cpp @@ -19,6 +19,13 @@ using v8::Persistent; using v8::String; using v8::Boolean; using v8::Value; +using v8::NewStringType; + +#if V8_MAJOR_VERSION >= 7 +#define CHECK_SET(X) X.Check() +#else +#define CHECK_SET(X) (void)X +#endif Persistent BloomFilterWrap::constructor; @@ -44,8 +51,10 @@ void BloomFilterWrap::Init(Local exports) { constructor.Reset(isolate, tpl->GetFunction( isolate->GetCurrentContext()).ToLocalChecked()); - exports->Set(String::NewFromUtf8(isolate, "BloomFilter"), - tpl->GetFunction(isolate->GetCurrentContext()).ToLocalChecked()); + CHECK_SET(exports->Set(isolate->GetCurrentContext(), String::NewFromUtf8(isolate, "BloomFilter", NewStringType::kNormal).ToLocalChecked(), + tpl->GetFunction(isolate->GetCurrentContext()).ToLocalChecked())); + // exports->Set(String::NewFromUtf8(isolate, "BloomFilter"), + // tpl->GetFunction(isolate->GetCurrentContext()).ToLocalChecked()); } void BloomFilterWrap::New(const FunctionCallbackInfo& args) { From fa52facbd2f1fc960b770c20dd93d3d722d4258b Mon Sep 17 00:00:00 2001 From: mailtokartik1 Date: Wed, 31 Jul 2019 16:46:45 +0900 Subject: [PATCH 2/3] change bloom filter export setClass --- BloomFilterWrap.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BloomFilterWrap.cpp b/BloomFilterWrap.cpp index e382b53..0a1733f 100644 --- a/BloomFilterWrap.cpp +++ b/BloomFilterWrap.cpp @@ -42,7 +42,8 @@ void BloomFilterWrap::Init(Local exports) { // Prepare constructor template Local tpl = FunctionTemplate::New(isolate, New); - tpl->SetClassName(String::NewFromUtf8(isolate, "BloomFilter")); + //tpl->SetClassName(String::NewFromUtf8(isolate, "BloomFilter")); + tpl->SetClassName(String::NewFromUtf8(isolate, "BloomFilter", NewStringType::kNormal).ToLocalChecked()); tpl->InstanceTemplate()->SetInternalFieldCount(1); // Prototype From f482931b070ecc62273d002291c5588fe3ba4e26 Mon Sep 17 00:00:00 2001 From: mailtokartik1 Date: Wed, 31 Jul 2019 17:02:09 +0900 Subject: [PATCH 3/3] cleanup --- BloomFilterWrap.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/BloomFilterWrap.cpp b/BloomFilterWrap.cpp index 0a1733f..abff3f2 100644 --- a/BloomFilterWrap.cpp +++ b/BloomFilterWrap.cpp @@ -42,7 +42,6 @@ void BloomFilterWrap::Init(Local exports) { // Prepare constructor template Local tpl = FunctionTemplate::New(isolate, New); - //tpl->SetClassName(String::NewFromUtf8(isolate, "BloomFilter")); tpl->SetClassName(String::NewFromUtf8(isolate, "BloomFilter", NewStringType::kNormal).ToLocalChecked()); tpl->InstanceTemplate()->SetInternalFieldCount(1); @@ -54,8 +53,6 @@ void BloomFilterWrap::Init(Local exports) { isolate->GetCurrentContext()).ToLocalChecked()); CHECK_SET(exports->Set(isolate->GetCurrentContext(), String::NewFromUtf8(isolate, "BloomFilter", NewStringType::kNormal).ToLocalChecked(), tpl->GetFunction(isolate->GetCurrentContext()).ToLocalChecked())); - // exports->Set(String::NewFromUtf8(isolate, "BloomFilter"), - // tpl->GetFunction(isolate->GetCurrentContext()).ToLocalChecked()); } void BloomFilterWrap::New(const FunctionCallbackInfo& args) {