Remove omit required field check customization, update devconfig

Author: peterrsongg

generator/.DevConfigs/40104287-a6e4-47b5-abcc-df8a1b50de48.json

@@ -4,7 +4,7 @@
       "serviceName": "S3",
       "type": "patch",
       "changeLogMessages": [
-        "Generate PutBucketMetricsConfiguration, GetBucketMetricsConfiguration,ListBucketMetricsConfiguration and DeleteBucketMetricsConfiguration"
+        "Generate PutBucketMetricsConfiguration, and add check in marshallers for required query strings. If required members for query strings are not set, the SDK will throw the base service-level exception."
       ]
     }
   ]

generator/.DevConfigs/de36e342-fb55-4e5f-85d1-e0fff6f0ec93.json

@@ -0,0 +1,9 @@
+{
+  "core": {
+    "updateMinimum": true,
+    "type": "patch",
+    "changeLogMessages": [
+      "Add check to see if required query string parameters areany required query string parameter is not set, then the SDK will throw the generic service level exception"
+    ]
+  }
+}

generator/ServiceClientGeneratorLib/Customizations.cs

@@ -1449,7 +1449,6 @@ public class PropertyModifier
             public const string SkipSetterKey = "skipSetter";
             public const string InjectXmlMarshallCodeKey = "injectXmlMarshallCode";
             public const string SkipXmlIsSetKey = "skipXmlIsSet";
-            public const string OmitRequiredFieldCheckKey = "omitRequiredFieldCheck";
 
             private readonly string _modelPropertyName;
             private readonly JsonData _modifierData;
@@ -1707,11 +1706,6 @@ public HashSet<string> InjectXmlUnmarshallCode
             /// }
             /// </summary>
             public bool SkipContextTestExpressionUnmarshallingLogic { get { return _modifierData[SkipContextTestExpressionUnmarshallingLogicKey] != null; } }
-
-            /// <summary>
-            /// If this is set, the check for a required field in the marshaller will be skipped. Default is false, meaning we will generate the required field check.
-            /// </summary>
-            public bool OmitRequiredFieldCheck { get { return _modifierData[OmitRequiredFieldCheckKey] != null && _modifierData[OmitRequiredFieldCheckKey].IsBoolean ? (bool)_modifierData[OmitRequiredFieldCheckKey] : false; } }
         }
 
         #endregion

generator/ServiceClientGeneratorLib/Generators/Marshallers/BaseMarshaller.cs

@@ -262,19 +262,18 @@ using Amazon.Runtime.Internal.Util;
                 // in many cases (s3 specifically, even if the member is required we do not throw a System.ArgumentException)
                 if (member.IsRequired)
                 {
-                    bool omitIsRequiredCheck = this.Config.ServiceModel.Customizations.TryGetPropertyModifier(member.OwningShape.Name, member.ModeledName, out var modifier) && modifier.OmitRequiredFieldCheck;
-                    if (member.Shape.IsString && !omitIsRequiredCheck)
+                    if (member.Shape.IsString)
                     {
 #>
             if (string.IsNullOrEmpty(<#=variableName#>.<#=member.PropertyName#>))
-                throw new System.ArgumentException("<#=member.PropertyName#> is a required property and must be set before making this call.", "<#=operation.Name#>Request.<#=member.PropertyName#>");
+                throw new <#=this.Config.BaseException#>("Request object does not have required field <#=member.PropertyName#> set");
 <#+
                     }
-                    else if (!member.Shape.IsString && !omitIsRequiredCheck)
+                    else
                     {
 #>
             if (<#=variableName#>.<#=member.PropertyName#> == null)
-                throw new System.ArgumentException("<#=member.PropertyName#> is a required property and must be set before making this call.", "<#=operation.Name#>Request.<#=member.PropertyName#>");
+                throw new <#=this.Config.BaseException#>("Request object does not have required field <#=member.PropertyName#> set");
 <#+
                     }
                 }