allow deploying to multiple stacks in the same account #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for CAPABILITY_NAMED_IAM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using named roles prevents this stack from being deployed to multiple clusters in the same AWS account, and requires CAPABILITY_NAMED_IAM.
Physical role names aren't really important for the functioning here, and removing role names lets CFN auto-generate unique names, so the stack can be deployed safely multiple times in the same account to work with different clusters, and requires lower capabilities for deployment
Description of changes: Removed role names to let CFN automatically generate them
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.