fix: update error handling in ValidateBricks to yield all validation errors instead of the first one

Author: dido18

internal/orchestrator/app/parser.go

@@ -21,10 +21,11 @@ import (
 	"io"
 
 	emoji "github.com/Andrew-M-C/go.emoji"
-	"github.com/arduino/arduino-app-cli/internal/orchestrator/bricksindex"
 	"github.com/arduino/go-paths-helper"
 	"github.com/goccy/go-yaml"
 	"github.com/goccy/go-yaml/ast"
+
+	"github.com/arduino/arduino-app-cli/internal/orchestrator/bricksindex"
 )
 
 type Brick struct {

internal/orchestrator/orchestrator.go

@@ -122,9 +122,13 @@ func StartApp(
 		ctx, cancel := context.WithCancel(ctx)
 		defer cancel()
 
-		err := app.Descriptor.ValidateBricks(bricksIndex)
-		if err != nil {
-			yield(StreamMessage{error: err})
+		errs := app.Descriptor.ValidateBricks(bricksIndex)
+		if errs != nil {
+			for _, e := range errs {
+				if !yield(StreamMessage{error: e}) {
+					return
+				}
+			}
 			return
 		}
 
@@ -453,9 +457,13 @@ func RestartApp(
 		ctx, cancel := context.WithCancel(ctx)
 		defer cancel()
 
-		err := appToStart.Descriptor.ValidateBricks(bricksIndex)
-		if err != nil {
-			yield(StreamMessage{error: err})
+		errs := appToStart.Descriptor.ValidateBricks(bricksIndex)
+		if errs != nil {
+			for _, e := range errs {
+				if !yield(StreamMessage{error: e}) {
+					return
+				}
+			}
 			return
 		}