Change Rook Ceph MON replacement section #382
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update vSphere install instructions for OpenShift 4.16
DebakelOrakel
changed the title
simu
requested changes
Feb 7, 2025
Member
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
The commit in the PR looks weird btw.
| [source,bash,subs="attributes+"] | ||
| ---- | ||
| mon_id=<MON_ID> | ||
| kubectl --as=cluster-admin -n syn-rook-ceph-cluster delete pod \ |
Member
There was a problem hiding this comment.
Why didn't this work (anymore)? I'm not happy with replacing a simple step which should trigger the rook operator to do the right thing with a fully manual step that can cause massive chaos.
Comment on lines
+66
to
+76
| # Remove MON to replace from ConfigMap | ||
| # | ||
| # data: | ||
| # csi-cluster-config-json: '[{"clusterID":"syn-rook-ceph-cluster","monitors":["194.182.183.35:6789","194.182.180.80:6789","194.182.181.220:6789"],"cephFS":{"netNamespaceFilePath":"","subvolumeGroup":"","kernelMountOptions":"","fuseMountOptions":""},"rbd":{"netNamespa ceFilePath":"","radosNamespace":""},"nfs":{"netNamespaceFilePath":""},"readAffinity":{"enabled":false,"crushLocationLabels":null},"namespace":""}]' | ||
| # data: h=194.182.183.35:6789,j=194.182.180.80:6789,i=194.182.181.220:6789 | ||
| # mapping: '{"node":{"h":{"Name":"storage-efb1","Hostname":"storage-efb1","Address":"194.182.183.35"},"i":{"Name":"storage-8bb1","Hostname":"storage-8bb1","Address":"194.182.181.220"},"j":{"Name":"storage-a79d","Hostname":"storage-a79d","Address":"194.182.180.80"}}}' | ||
| kubectl --as=cluster-admin -n syn-rook-ceph-cluster edit cm rook-ceph-mon-endpoints | ||
| # data: | ||
| # csi-cluster-config-json: '[{"clusterID":"syn-rook-ceph-cluster","monitors":["194.182.180.80:6789","194.182.181.220:6789"],"cephFS":{"netNamespaceFilePath":"","subvolumeGroup":"","kernelMountOptions":"","fuseMountOptions":""},"rbd":{"netNamespa ceFilePath":"","radosNamespace":""},"nfs":{"netNamespaceFilePath":""},"readAffinity":{"enabled":false,"crushLocationLabels":null},"namespace":""}]' | ||
| # data: j=194.182.180.80:6789,i=194.182.181.220:6789 | ||
| # mapping: '{"node":{"i":{"Name":"storage-8bb1","Hostname":"storage-8bb1","Address":"194.182.181.220"},"j":{"Name":"storage-a79d","Hostname":"storage-a79d","Address":"194.182.180.80"}}}' |
Member
There was a problem hiding this comment.
If we actually want to make this the process, this must be a kubectl patch and not a kubectl edit and hope no mistakes happen. Otherwise this must be a 4-eyes process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of MON pods does not work as described