CASSGO-91 Prefer connection address over system local addresses #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshartig
reviewed
Oct 10, 2025
joao-r-reis
force-pushed
the
systemlocaladdress
branch
from
bc30a7e to
d1f70d0
Compare
|
Pushed a change to this line here, this might fix #1873 |
jameshartig
reviewed
Oct 10, 2025
host_source.go
Outdated
| } | ||
|
|
||
| host, err := r.session.hostInfoFromIter(iter, nil, r.session.cfg.Port) | ||
| host, err := r.session.hostInfoFromIter(iter, iter.host.connectAddress, r.session.cfg.Port) |
There was a problem hiding this comment.
Doesn't this need to lock mu? Do we need a new function that's like ActualConnectAddress that does the locking?
There was a problem hiding this comment.
oh you're right I think, I should probably use host.ConnectAddress() instead
There was a problem hiding this comment.
actually ConnectAddress() will do all the logic to falback to other columns so I probably need to add a new method
joao-r-reis
force-pushed
the
systemlocaladdress
branch
from
d1f70d0 to
8f77051
Compare
joao-r-reis
force-pushed
the
systemlocaladdress
branch
from
8f77051 to
cf12fa1
Compare
jameshartig
approved these changes
Oct 10, 2025
There is an unintended change in 2.0-rc1 causing the driver to prefer system table addresses over the connection address which breaks deployments that rely on this behavior from 1.x. This patch fixes this and keeps the behavior the same as it was in 1.x. It also fixes an issue where connection address was not being used when a full ring refresh was triggered. Patch by João Reis; reviewed by James Hartig for CASSGO-91
joao-r-reis
force-pushed
the
systemlocaladdress
branch
from
cf12fa1 to
7e4069e
Compare
good point, done |
joao-r-reis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an unintended change in 2.0-rc1 causing the driver to prefer system table addresses over the connection address which breaks deployments that rely on this behavior from 1.x.
This patch fixes this and keeps the behavior the same as it was in 1.x.