FEAT: Job manager concurrent job bug (#1640)

* adding CLI for batch submission

* adding CLI for batch submission

* chore: adding changelog file 1635.added.md [dependabot-skip]

* siwave valcheck

* job manager max concurrent cli

* chore: adding changelog file 1640.added.md [dependabot-skip]

* job service modified

* local job with massive job fixed

* local job with massive job fixed #3

* Val fix

---------

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Author: svandenb-dev

doc/changelog.d/1635.added.md

@@ -0,0 +1 @@
+Adding CLI for batch submission

doc/changelog.d/1640.added.md

@@ -0,0 +1 @@
+Job manager concurrent job bug

doc/source/workflows/drc/drc.rst

@@ -1,7 +1,7 @@
 .. _ref_drc:
 
 ==================================================================
-Design-rule checking (DRC)–self-contained, multi-threaded engine
+Design-rule checking (DRC)—self-contained, multi-threaded engine
 ==================================================================
 
 .. currentmodule:: pyedb.workflows.drc.drc
@@ -85,7 +85,7 @@ Rule models
    BackDrillStubLength
    CopperBalance
 
-DRC engine
+DRC Engine
 ~~~~~~~~~~
 
 .. autosummary::
@@ -129,7 +129,7 @@ Load a rule deck from JSON
        rules = Rules.from_dict(json.load(f))
 
 Export violations to CSV
-~~~~~~~~~~~~~~~~~~~~~~~~
+~~~~~~~~~~~~~~~~~~~~~~~~~
 
 .. code-block:: python
 

doc/source/workflows/job_manager/submit_job.rst

@@ -44,7 +44,7 @@ It exposes:
 * REST & Web-Socket endpoints (``http://localhost:8080`` by default)
 * Thread-safe synchronous façade for scripts / Jupyter
 * Native async API for advanced integrations
-* CLI utilities ``submit_local_job`` and ``submit_job_on_scheduler`` for shell / CI pipelines
+* CLI utilities ``submit_local_job``, ``submit_batch_jobs``, and ``submit_job_on_scheduler`` for shell / CI pipelines
 
 The **same backend code path** is used regardless of front-end style; the difference is
 **who owns the event loop** and **how control is returned to the caller**.
@@ -176,6 +176,130 @@ Example—CLI (cluster)
 The command returns immediately after the job is **queued**; use the printed ID
 with ``wait_until_done`` or monitor via the web UI.
 
+CLI—``submit_batch_jobs``
+^^^^^^^^^^^^^^^^^^^^^^^^^^
+For bulk submissions, use ``submit_batch_jobs`` to automatically discover and submit
+multiple projects from a directory tree.
+
+Synopsis
+""""""""
+.. code-block:: bash
+
+   $ python submit_batch_jobs.py --root-dir <DIRECTORY> [options]
+
+Key features
+""""""""""""
+* **Automatic discovery**: Scans for all ``.aedb`` folders and ``.aedt`` files
+* **Smart pairing**: When both ``.aedb`` and ``.aedt`` exist, uses the ``.aedt`` file
+* **Asynchronous submission**: Submits jobs concurrently for faster processing
+* **Recursive scanning**: Optional recursive directory traversal
+
+Options
+"""""""
+.. list-table::
+   :widths: 30 15 55
+   :header-rows: 1
+
+   * - Argument
+     - Default
+     - Description
+   * - ``--root-dir``
+     - *(required)*
+     - Root directory to scan for projects
+   * - ``--host``
+     - ``localhost``
+     - Job manager host address
+   * - ``--port``
+     - ``8080``
+     - Job manager port
+   * - ``--num-cores``
+     - ``8``
+     - Number of cores to allocate per job
+   * - ``--max-concurrent``
+     - ``5``
+     - Maximum concurrent job submissions
+   * - ``--delay-ms``
+     - ``100``
+     - Delay in milliseconds between job submissions
+   * - ``--recursive``
+     - ``False``
+     - Scan subdirectories recursively
+   * - ``--verbose``
+     - ``False``
+     - Enable debug logging
+
+Example—batch submission (local)
+"""""""""""""""""""""""""""""""""
+.. code-block:: bash
+
+   # Submit all projects in a directory
+   $ python submit_batch_jobs.py --root-dir "D:\Temp\test_jobs"
+
+   # Recursive scan with custom core count
+   $ python submit_batch_jobs.py \
+         --root-dir "D:\Projects\simulations" \
+         --num-cores 16 \
+         --recursive \
+         --verbose
+
+Example output
+""""""""""""""
+.. code-block:: text
+
+   2025-11-07 10:30:15 - __main__ - INFO - Scanning D:\Temp\test_jobs for projects (recursive=False)
+   2025-11-07 10:30:15 - __main__ - INFO - Found AEDB folder: D:\Temp\test_jobs\project1.aedb
+   2025-11-07 10:30:15 - __main__ - INFO - Found AEDT file: D:\Temp\test_jobs\project2.aedt
+   2025-11-07 10:30:15 - __main__ - INFO - Using AEDB folder for project: D:\Temp\test_jobs\project1.aedb
+   2025-11-07 10:30:15 - __main__ - INFO - Using standalone AEDT file: D:\Temp\test_jobs\project2.aedt
+   2025-11-07 10:30:15 - __main__ - INFO - Found 2 project(s) to submit
+   2025-11-07 10:30:15 - __main__ - INFO - Starting batch submission of 2 project(s) to http://localhost:8080
+   2025-11-07 10:30:16 - __main__ - INFO - ✓ Successfully submitted: project1.aedb (status=200)
+   2025-11-07 10:30:16 - __main__ - INFO - ✓ Successfully submitted: project2.aedt (status=200)
+   2025-11-07 10:30:16 - __main__ - INFO - ============================================================
+   2025-11-07 10:30:16 - __main__ - INFO - Batch submission complete:
+   2025-11-07 10:30:16 - __main__ - INFO -   Total projects: 2
+   2025-11-07 10:30:16 - __main__ - INFO -   ✓ Successful: 2
+   2025-11-07 10:30:16 - __main__ - INFO -   ✗ Failed: 0
+   2025-11-07 10:30:16 - __main__ - INFO - ============================================================
+
+How it works
+""""""""""""
+1. **Scanning phase**:
+
+   * Searches for all ``.aedb`` folders in the root directory
+   * Searches for all ``.aedt`` files in the root directory
+   * For each ``.aedb`` folder, checks if a corresponding ``.aedt`` file exists:
+
+     - If yes: Uses the ``.aedt`` file
+     - If no: Uses the ``.aedb`` folder
+
+   * Standalone ``.aedt`` files (without corresponding ``.aedb``) are also included
+
+2. **Submission phase**:
+
+   * Creates job configurations for each project
+   * Submits jobs asynchronously to the job manager REST API
+   * Limits concurrent submissions using a semaphore (default: 5)
+   * Reports success/failure for each submission
+
+3. **Results**:
+
+   * Displays a summary with total, successful, and failed submissions
+   * Logs detailed information about each submission
+
+.. note::
+   The script does **not** wait for jobs to complete, only for submission confirmation.
+   Job execution happens asynchronously in the job manager service.
+
+.. tip::
+   * Use ``--max-concurrent`` to limit load on the job manager service when submitting
+     large batches.
+   * Use ``--delay-ms`` to control the pause between submissions (default: 100ms).
+     This ensures HTTP requests are fully sent before the next submission starts.
+   * Set ``--delay-ms 0`` to disable the delay if your network is very fast and reliable.
+   * For very large batch submissions, consider increasing the timeout in the code if
+     network latency is high.
+
 Programmatic—native asyncio
 """""""""""""""""""""""""""""
 .. code-block:: python

ignore_words.txt

@@ -32,3 +32,7 @@ aline
 COM
 gRPC
 Toolkits
+Cohn
+Pydantic
+pydantic
+Drc

src/pyedb/workflows/job_manager/backend/job_manager_handler.py

@@ -231,8 +231,9 @@ def __init__(self, edb=None, version=None, host="localhost", port=8080):
                 else:
                     self.ansys_path = os.path.join(installed_versions[version], "ansysedt.exe")
         self.scheduler_type = self._detect_scheduler()
-        self.manager = JobManager(scheduler_type=self.scheduler_type)
-        self.manager.resource_limits = ResourceLimits(max_concurrent_jobs=1)
+        # Create resource limits with default values
+        resource_limits = ResourceLimits(max_concurrent_jobs=1)
+        self.manager = JobManager(resource_limits=resource_limits, scheduler_type=self.scheduler_type)
         self.manager.jobs = {}  # In-memory job store -TODO add persistence database
         # Pass the detected ANSYS path to the manager
         self.manager.ansys_path = self.ansys_path

src/pyedb/workflows/job_manager/backend/job_submission.py

@@ -68,6 +68,7 @@
 from datetime import datetime
 import enum
 import getpass
+import hashlib
 import logging
 import os
 import platform
@@ -77,6 +78,7 @@
 import subprocess  # nosec B404
 import tempfile
 from typing import Any, Dict, List, Optional, Union
+import uuid
 
 from pydantic import BaseModel, Field
 
@@ -468,7 +470,12 @@ def __init__(self, **data):
             else:
                 self.ansys_edt_path = os.path.join(list(installed_versions.values())[-1], "ansysedt.exe")  # latest
         if not self.jobid:
-            self.jobid = f"JOB_ID_{datetime.now().strftime('%Y%m%d_%H%M%S')}"
+            # Generate unique job ID using timestamp and UUID to avoid collisions
+            # when submitting multiple jobs rapidly (batch submissions)
+            timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
+            # Use short UUID (first 8 chars) for readability while ensuring uniqueness
+            unique_id = str(uuid.uuid4())[:8]
+            self.jobid = f"JOB_{timestamp}_{unique_id}"
         if "auto" not in data:  # user did not touch it
             data["auto"] = self.scheduler_type != SchedulerType.NONE
         self.validate_fields()