FORMS-18096 : Accessibility Issues with Radio Buttons in Adaptive form Core component #1744

armaang1729 · 2025-10-28T17:05:12Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2025-10-28T17:44:14Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-10-29T07:23:31Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-10-29T09:10:43Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-10-29T09:11:38Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-10-29T09:39:56Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-10-29T09:40:40Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

codecov · 2025-10-29T09:47:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

adobe-bot · 2025-11-03T05:02:16Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-03T05:03:35Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-11-03T17:02:54Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-03T17:09:37Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-11-04T01:50:07Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T13:15:24Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-11-06T13:16:19Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T13:21:11Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T13:22:42Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

…dded its dam

adobe-bot · 2025-11-06T14:03:05Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T14:03:11Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T14:03:42Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T16:02:10Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T16:07:51Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T16:32:53Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T16:33:15Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T16:44:24Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-06T16:45:41Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-07T07:44:29Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-11-07T07:45:47Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-07T14:11:52Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-07T14:14:45Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-10T10:55:24Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-10T10:55:38Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-10T10:55:48Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-10T10:56:42Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-10T13:49:22Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-10T15:53:07Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

…g the radio buttons

adobe-bot · 2025-11-11T07:38:39Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-11-11T07:39:58Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

rismehta · 2025-11-12T05:35:31Z

...pps/core/fd/components/form/radiobutton/v2/radiobutton/clientlibs/site/js/radiobuttonview.js

+(function() {
+
+    "use strict";
+    class RadioButton extends FormView.FormOptionFieldBase {


What are the changes here ?

sir as we are now using the fieldset and legend so now we don't need the aira-label attributes on the input level

armaang1729 · 2025-11-12T05:40:02Z

...pps/core/fd/components/form/radiobutton/v2/radiobutton/clientlibs/site/js/radiobuttonview.js

+            const optionTemplate = `
+            <div class="${RadioButton.selectors.option.slice(1)}">
+                <label class="${RadioButton.selectors.optionLabel.slice(1)}">
+                    <input type="radio" name="${this._model.name}" class="${RadioButton.selectors.widget.slice(1)}" value="${value}" tabindex="0">


sir the change is here in which we are adding the aria-label to new input which is created dynamically, to avoid adding the aria labels we have removed it from here for the version v2

added the fieldset and legend for the radiobutton

357ffb7

github-actions bot force-pushed the FORMS-18096 branch from c4b9b87 to 357ffb7 Compare October 28, 2025 17:05

added check for the label-element

04b4740

armaang1729 and others added 2 commits October 29, 2025 14:06

Delete files

7f17e6c

code refactoring

ac453c7

added sample forms and cypress testing

5c2ebf8

armaang1729 force-pushed the FORMS-18096 branch from 3980a0d to 5c2ebf8 Compare November 6, 2025 12:38

removed the unused forms from DAM

74aa775

Armaan Gupta added 3 commits November 6, 2025 19:01

modified the resourceType to point to older version of radiobutton

4a12bfe

updated the path for the custom functions populate-radiobutton

07ce1c6

made new collateral for custom functions populate-radiobuttonv2 and a…

1cee379

…dded its dam

added custom function test for the radioButton v2

6cfead8

armaang1729 force-pushed the FORMS-18096 branch from acf80b8 to 6cfead8 Compare November 7, 2025 07:10

updated README for the radiobuttonv2 component

fac95ea

Armaan Gupta added 2 commits November 10, 2025 15:07

added clientlibs for newer version of radiobutton

07210f6

updated af-clientlibs version for the radiobutton

fa8abca

Armaan Gupta added 2 commits November 11, 2025 12:28

removed the role of the radio group aria-label on the <div> containin…

006aa35

…g the radio buttons

updated the cypress tests

9b05525

armaang1729 changed the title ~~Forms 18096 <Work in progress>~~ FORMS-18096 : Accessibility Issues with Radio Buttons in Adaptive form Core component Nov 12, 2025

armaang1729 requested a review from rismehta November 12, 2025 05:21

rismehta reviewed Nov 12, 2025

View reviewed changes

armaang1729 commented Nov 12, 2025

View reviewed changes

armaang1729 requested a review from rismehta November 12, 2025 06:28

FORMS-18096 : Accessibility Issues with Radio Buttons in Adaptive form Core component #1744

Are you sure you want to change the base?

FORMS-18096 : Accessibility Issues with Radio Buttons in Adaptive form Core component #1744

Uh oh!

Conversation

armaang1729 commented Oct 28, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

adobe-bot commented Oct 28, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Oct 29, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Oct 29, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Oct 29, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Oct 29, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Oct 29, 2025

Accessibility Violations Found

Uh oh!

codecov bot commented Oct 29, 2025

Codecov Report

Uh oh!

adobe-bot commented Nov 3, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 3, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 3, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 3, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 4, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Nov 6, 2025

Accessibility Violations Found

Uh oh!

armaang1729 Nov 12, 2025 •

edited

Loading