-
Notifications
You must be signed in to change notification settings - Fork 200
[Wwise] Fixed Wwise SDK API Change to Wwise 2024.1.7 #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| pathingParams.binaural = m_params->NonRTPC.pathingBinaural ? IPL_TRUE : IPL_FALSE; | ||
| pathingParams.hrtf = hrtf; | ||
| pathingParams.listener = listenerCoords; | ||
| pathingParams.normalizeEQ = m_params->NonRTPC.pathingNormalizeEQ ? IPL_TRUE : IPL_FALSE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this deleted? Does the build fail on newer versions of Wwise with this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPLPathEffectParams removed the normalizeEQ member in recent versions of Wwise. The normalization is handled automatically so the argument is deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this deleted? Does the build fail on newer versions of Wwise with this line?
Yes, Wwise 2024.1.5 or newer will fail the build with the related UE 5 versions. Therefore, any UE 5.4, 5.5, or even 5.6 projects with Wwise will NOT BE ABLE to use Steam Audio at this time (unless they can endure the numerous crashes)
| #include "../SteamAudioWwisePlugin.h" | ||
|
|
||
| class SteamAudioSpatializerPluginGUI final : public AK::Wwise::Plugin::PluginMFCWindows<>, public AK::Wwise::Plugin::GUIWindows | ||
| class SteamAudioSpatializerPluginGUI final : public AK::Wwise::Plugin::GUIWindows<>, public AK::Wwise::Plugin::GUIWindows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you surround this rename with #ifdef etc. so that the code can still be compiled by users who need to use older versions of Wwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you surround this rename with
#ifdefetc. so that the code can still be compiled by users who need to use older versions of Wwise?
I committed and added backward compatibility, please check. By the way, the original code was weird, that it inherited two base classes. This PR will fix this as well.
This PR updates the Wwise integration to Wwise 2024.1.7:
After this fix, steam audio wwise is able to successfully compile with UE 5.5.4 & Steam Audio 4.7.0.
Backward compatibility was added for older Wwise versions