Try again with the instance outside the loop and clean up RetryAction

Author: mythz

tests/Console.Tests/HashCollectionStressTests.cs

@@ -45,11 +45,11 @@ public void Execute(string ipAddress, int noOfThreads = 64)
 
         public void WorkerLoop()
         {
+            var redisCollection = new RedisCachedCollection<string, string>(
+                clientsManager, "Thread: " + Thread.CurrentThread.ManagedThreadId);
+
             while (Interlocked.CompareExchange(ref running, 0, 0) > 0)
             {
-                var redisCollection = new RedisCachedCollection<string, string>(
-                    clientsManager, "Thread: " + Thread.CurrentThread.ManagedThreadId);
-
                 redisCollection.ContainsKey("key");
                 Interlocked.Increment(ref readCount);
 
@@ -241,29 +241,19 @@ public Func<TValue, TKey> GetUniqueIdAction
 
         private void RetryAction(Action<IRedisClient> action)
         {
-            int i = 0;
-            while (true)
+            try
             {
-                try
+                using (var redis = RedisConnection)
                 {
-                    using (var redis = RedisConnection)
-                    {
-                        action(redis);
-                        return;
-                    }
-                }
-                catch (Exception ex)
-                {
-                    Console.WriteLine(ex);
-                    throw;
-
-                    //if (i++ < 3)
-                    //{
-                    //    continue;
-                    //}
-                    //throw;
+                    action(redis);
+                    return;
                 }
             }
+            catch (Exception ex)
+            {
+                Console.WriteLine(ex);
+                throw;
+            }
         }
 
         private TOut RetryAction<TOut>(Func<IRedisClient, TOut> action)