1.12.3 (#334)

* new version

* fixing object creation date check in trdir

* fixing broken unit test due to dependency

* fixing reversal threshold validation

* reverting change

* reverting changes

* Update changelog.txt

Author: lucasborin

changelog.txt

@@ -12,6 +12,11 @@ Upgrade Note
 ------------------
 Whenever you upgrade code pal for ABAP, it is highly recommended to execute the Y_CI_CHECK_REGISTRATION report to activate/reactivate the Checks (SE38 transaction) and regenerate the respective code inspector variant (SCI transaction)
 
+2021-02-24 v1.12.3
+------------------
+* Object Creation Date from TRDIR table
+* Reversal Thresholds Validation
+
 2021-02-09 v1.12.2
 ------------------
 * Code Pal Exempts All the Sub-Objects (#326)

src/foundation/y_check_base.clas.abap

@@ -242,6 +242,7 @@ CLASS y_check_base IMPLEMENTATION.
       CLEAR result.
       RETURN.
     ENDIF.
+
   ENDMETHOD.
 
 
@@ -746,7 +747,7 @@ CLASS y_check_base IMPLEMENTATION.
 
 
   METHOD is_skipped.
-    result = xsdbool( ( config-threshold <= error_count AND settings-is_threshold_reversed = abap_true ) OR
+    result = xsdbool( ( config-threshold < error_count AND settings-is_threshold_reversed = abap_true ) OR
                       ( config-threshold > error_count AND settings-is_threshold_reversed = abap_false ) OR
                       ( is_testcode = abap_true AND config-apply_on_testcode = abap_false ) OR
                       ( is_testcode = abap_false AND config-apply_on_productive_code = abap_false ) ).

src/foundation/y_object_creation_date.clas.abap

@@ -137,7 +137,7 @@ CLASS y_object_creation_date IMPLEMENTATION.
     DELETE creation_dates WHERE cdat IS INITIAL.
 
     TRY.
-        result = creation_dates[ 0 ].
+        result = creation_dates[ 1 ].
       CATCH cx_sy_itab_line_not_found.
         CLEAR result.
     ENDTRY.

src/y_code_pal_version.intf.abap

@@ -1,3 +1,3 @@
 INTERFACE y_code_pal_version PUBLIC.
-  CONSTANTS abap TYPE string VALUE '1.12.2' ##NO_TEXT.
+  CONSTANTS abap TYPE string VALUE '1.12.3' ##NO_TEXT.
 ENDINTERFACE.