Merge pull request #921 from softworkz/submit_missing_locks

FlorianRappl · web-flow · commit 14bf7fdcd82b · 2025-11-10T22:27:02.000+01:00
SocketIOFacade: Add missing locking on .Off calls
diff --git a/src/ElectronNET.API/Bridge/SocketIOFacade.cs b/src/ElectronNET.API/Bridge/SocketIOFacade.cs
@@ -86,7 +86,7 @@ public void Once(string eventName, Action action)
         {
             _socket.On(eventName, _ =>
             {
-                _socket.Off(eventName);
+                this.Off(eventName);
                 Task.Run(action);
             });
         }
@@ -98,7 +98,7 @@ public void Once<T>(string eventName, Action<T> action)
         {
             _socket.On(eventName, (socketIoResponse) =>
             {
-                _socket.Off(eventName);
+                this.Off(eventName);
                 Task.Run(() => action(socketIoResponse.GetValue<T>()));
             });
         }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public void Once(string eventName, Action action)`
`86`	`86`	`{`
`87`	`87`	`_socket.On(eventName, _ =>`
`88`	`88`	`{`
`89`		`- _socket.Off(eventName);`
	`89`	`+ this.Off(eventName);`
`90`	`90`	`Task.Run(action);`
`91`	`91`	`});`
`92`	`92`	`}`
`@@ -98,7 +98,7 @@ public void Once<T>(string eventName, Action<T> action)`
`98`	`98`	`{`
`99`	`99`	`_socket.On(eventName, (socketIoResponse) =>`
`100`	`100`	`{`
`101`		`- _socket.Off(eventName);`
	`101`	`+ this.Off(eventName);`
`102`	`102`	`Task.Run(() => action(socketIoResponse.GetValue<T>()));`
`103`	`103`	`});`
`104`	`104`	`}`