clean up pimpl

not sure why i didn't do this initially :P

Author: Prevter

include/recorder.hpp

@@ -25,6 +25,36 @@ class AVFilterGraph;
 BEGIN_FFMPEG_NAMESPACE_V
 
 class FFMPEG_API_DLL Recorder {
+private:
+    class Impl {
+    public:
+        AVFormatContext* m_formatContext = nullptr;
+        const AVCodec* m_codec = nullptr;
+        AVStream* m_videoStream = nullptr;
+        AVCodecContext* m_codecContext = nullptr;
+        AVBufferRef* m_hwDevice = nullptr;
+        AVFrame* m_frame = nullptr;
+        AVFrame* m_convertedFrame = nullptr;
+        AVFrame* m_filteredFrame = nullptr;
+        AVPacket* m_packet = nullptr;
+        SwsContext* m_swsCtx = nullptr;
+        AVFilterGraph* m_filterGraph = nullptr;
+        AVFilterContext* m_buffersrcCtx = nullptr;
+        AVFilterContext* m_buffersinkCtx = nullptr;
+        AVFilterContext* m_colorspaceCtx = nullptr;
+        AVFilterContext* m_vflipCtx = nullptr;
+
+        size_t m_frameCount = 0;
+        bool m_init = false;
+
+        geode::Result<> init(const RenderSettings& settings);
+        void stop();
+        geode::Result<> writeFrame(const std::vector<uint8_t>& frameData);
+        geode::Result<> filterFrame(AVFrame* inputFrame, AVFrame* outputFrame);
+    };
+
+    std::unique_ptr<Impl> m_impl = nullptr;
+
 public:
     /**
      * @brief Initializes the Recorder with the specified rendering settings.
@@ -37,15 +67,18 @@ class FFMPEG_API_DLL Recorder {
      * 
      * @return true if initialization is successful, false otherwise.
      */
-    geode::Result<> init(const RenderSettings& settings);
+    geode::Result<> init(const RenderSettings& settings) {
+        m_impl = std::make_unique<Impl>();
+        return m_impl->init(settings);
+    }
 
     /**
      * @brief Stops the recording process and finalizes the output file.
      *
      * This function ensures that all buffered frames are written to the output file,
      * releases allocated resources, and properly closes the output file.
      */
-    void stop();
+    void stop() const { m_impl->stop(); }
 
     /**
      * @brief Writes a single video frame to the output.
@@ -60,7 +93,9 @@ class FFMPEG_API_DLL Recorder {
      * 
      * @warning Ensure that the frameData size matches the expected dimensions of the frame.
      */
-    geode::Result<> writeFrame(const std::vector<uint8_t>& frameData);
+    geode::Result<> writeFrame(const std::vector<uint8_t>& frameData) const {
+        return m_impl->writeFrame(frameData);
+    }
 
     /**
      * @brief Retrieves a list of available codecs for video encoding.
@@ -73,32 +108,9 @@ class FFMPEG_API_DLL Recorder {
     static std::vector<std::string> getAvailableCodecs();
 
 private:
-    geode::Result<> filterFrame(AVFrame* inputFrame, AVFrame* outputFrame);
-
-private:
-    class Impl {
-    public:
-        AVFormatContext* m_formatContext = nullptr;
-        const AVCodec* m_codec = nullptr;
-        AVStream* m_videoStream = nullptr;
-        AVCodecContext* m_codecContext = nullptr;
-        AVBufferRef* m_hwDevice = nullptr;
-        AVFrame* m_frame = nullptr;
-        AVFrame* m_convertedFrame = nullptr;
-        AVFrame* m_filteredFrame = nullptr;
-        AVPacket* m_packet = nullptr;
-        SwsContext* m_swsCtx = nullptr;
-        AVFilterGraph* m_filterGraph = nullptr;
-        AVFilterContext* m_buffersrcCtx = nullptr;
-        AVFilterContext* m_buffersinkCtx = nullptr;
-        AVFilterContext* m_colorspaceCtx = nullptr;
-        AVFilterContext* m_vflipCtx = nullptr;
-
-        size_t m_frameCount = 0;
-        bool m_init = false;
-    };
-
-    std::unique_ptr<Impl> m_impl = nullptr;
+    geode::Result<> filterFrame(AVFrame* inputFrame, AVFrame* outputFrame) const {
+        return m_impl->filterFrame(inputFrame, outputFrame);
+    }
 };
 
 END_FFMPEG_NAMESPACE_V