SF4 #88
Open
SF4 #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismail1432
suggested changes
Aug 18, 2018
ismail1432
left a comment
ismail1432
left a comment
There was a problem hiding this comment.
Nice job, thank you !
Can you update the ReadMe too ?
| use Symfony\Component\HttpFoundation\Request; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
| use Symfony\Component\Templating\EngineInterface; | ||
| use Twig_Environment; |
|
|
||
| /** | ||
| * @return KernelInterface | ||
| * @return |
| return 'coresphere_console'; | ||
| } | ||
|
|
||
| public function reset(){ |
There was a problem hiding this comment.
CS, be careful to PSR
public function reset()
{
}
| "symfony/event-dispatcher": "~2.7|~3.0|~4.0", | ||
| "symfony/framework-bundle": "~2.7|~3.0|~4.0", | ||
| "symfony/http-kernel": "~2.7|~3.0|~4.0" | ||
| "symfony/console": "~2.7|~4.0", |
There was a problem hiding this comment.
Are you that this modification works with SF <= 3.4 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.