Improve tests

Author: pentest-gg

fastapi_users_db_dynamodb/__init__.py

@@ -195,13 +195,16 @@ async def create(self, create_dict: dict[str, Any] | UP) -> UP:
         else:
             user = create_dict
         try:
-            await user.save(condition=self.user_table.id.does_not_exist())  # type: ignore
+            await user.save(  # type: ignore
+                condition=self.user_table.id.does_not_exist()
+                & self.user_table.email.does_not_exist()  # type: ignore
+            )
         except PutError as e:
             if e.cause_response_code == "ConditionalCheckFailedException":
                 raise ValueError(
                     "User account could not be created because it already exists."
                 ) from e
-            raise ValueError(
+            raise ValueError(  # pragma: no cover
                 "User account could not be created because the table does not exist."
             ) from e
         return user
@@ -220,7 +223,7 @@ async def update(self, user: UP, update_dict: dict[str, Any]) -> UP:
                 raise ValueError(
                     "User account could not be updated because it does not exist."
                 ) from e
-            raise ValueError(
+            raise ValueError(  # pragma: no cover
                 "User account could not be updated because the table does not exist."
             ) from e
 
@@ -254,7 +257,7 @@ async def add_oauth_account(self, user: UP, create_dict: dict[str, Any]) -> UP:
                 raise ValueError(
                     "OAuth account could not be added because it already exists."
                 ) from e
-            raise ValueError(
+            raise ValueError(  # pragma: no cover
                 "OAuth account could not be added because the table does not exist."
             ) from e
 

tests/test_users.py

@@ -84,6 +84,14 @@ async def test_queries(dynamodb_user_db: DynamoDBUserDatabase[User, UUID_ID]):
     # Update user
     updated_user = await dynamodb_user_db.update(user, {"is_superuser": True})
     assert updated_user.is_superuser is True
+    with pytest.raises(
+        ValueError,
+        match="User account could not be updated because it does not exist.",
+    ):
+        fake_user = User()
+        fake_user.email = "blabla@gmail.com"
+        fake_user.hashed_password = "crypticpassword"
+        await dynamodb_user_db.update(fake_user, {"is_superuser": True})
 
     # Get by id
     id_user = await dynamodb_user_db.get(user.id)
@@ -130,7 +138,13 @@ async def test_insert_existing_email(
         "email": "lancelot@camelot.bt",
         "hashed_password": "guinevere",
     }
-    await dynamodb_user_db.create(user_create)
+    user = await dynamodb_user_db.create(user_create)
+    with pytest.raises(
+        ValueError,
+        match="User account could not be created because it already exists.",
+    ):
+        user_create["id"] = str(user.id)
+        await dynamodb_user_db.create(user_create)
 
     with pytest.raises(ValueError):  # oder eigene Exception
         existing = await dynamodb_user_db.get_by_email(user_create["email"])