-
Notifications
You must be signed in to change notification settings - Fork 0
Updated UI to fit new figma design. This also contains the new search… #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sande11
wants to merge
37
commits into
master
Choose a base branch
from
131-update-tb-guide-android-app-ui-with-new-figma-design
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updated UI to fit new figma design. This also contains the new search… #132
sande11
wants to merge
37
commits into
master
from
131-update-tb-guide-android-app-ui-with-new-figma-design
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… view for body fragment
6 tasks
MaxwellKJr
requested changes
Sep 19, 2025
Contributor
MaxwellKJr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sande11 great work! This looks solid. Just a few things that you need to look into:
Align Chapter Cards text to the left
Web View Search Options Not Fitting On Small Devices
- Try reducing the horizontal padding of the parent layout and also the individual elements
Clear Search Field When Last letter has been cleared with the keyboard delete button
Dismiss the Keyboard when popping out of the WebView page
Dark Mode Not Working
screen-20250919-090219.webm
…ogic in search view
… Dialog_font text
… results duplication bug, keyboard not being dismissed, search loading icon stuck on screen, bookmark card cut off, search result tabs being clipped
Changed the text in body fragment to expand when display and font size of the display changes
… rest of the app and subchapter.json to remove a duplicate subchapter title
Author
private const val BUILD_VERSION = 12 private const val PENDO_RELEASE_VERSION = "Oct-25-"
…n' into 133-update-android-app-to-target-latest-api-level-and-google-sdks
…d-app-to-target-latest-api-level-and-google-sdks Revert "updated from API 34 to 35 in TB Guide android UI Updates"
- Bump compileSdk and targetSdk to 36 - Update dependencies to latest versions - Implement edge-to-edge layout in MainActivity - Add status bar background view in activity_main.xml - Add support for 16KB page size in gradle.properties
Updated tab container structure to improve appearance when font size is increased
Added logic to automatically expand collapsed dropdowns, tabs, and details elements that contain search results before performing in-page search. Also added a method to collapse expanded sections when clearing the search. Updated custom_action_bar_title.xml to use wrap_content for height with a minimum height of 56dp for better layout flexibility.
Changed the floating notes button margins and constraint to improve positioning. MarginEnd increased to 25dp, marginBottom added, and constraint now aligns to bottom_toolbar instead of search_view_include.
…app-ui-with-new-figma-design Merge the latest UI updates to API level update branch
Replaces removeLast() with removeAt(recentSearches.lastIndex) to remove the last item from the recent searches list, ensuring compatibility
Replaces removeLast() with removeAt(recentSearches.lastIndex) to remove the last item from the recent searches list, ensuring compatibility
…rget-latest-api-level-and-google-sdks 133 update android app to target latest api level and google sdks
Replaced launcher icons and round icons for all densities, updated ic_launcher_background.xml with a new vector design, and added ic_launcher_foreground assets to mipmap folders. Updated adaptive icon XMLs to reference foreground images from mipmap instead of drawable for proper icon rendering.
Corrected URLs for CDC TB case definitions and QuantiFERON-TB Gold Plus package insert. Updated chapter references in HIV therapy tables to point to the correct section. These changes improve accuracy and navigation for users.
Corrected the 'View in chapter' links in three HTML table pages to point to the appropriate chapter without fragment identifiers, ensuring consistency and proper navigation for users.
144 Fix Broken internal and External Links
Added custom selection and reselection handlers for bottom navigation to ensure consistent navigation to root fragments. Updated fragment_saved.xml to include bottom padding for navigation bar, and defined bottom_nav_height in dimens.xml.
Corrected image paths, improved table formatting, fixed HTML entities, and updated external links in multiple TB-related asset pages. These changes enhance clarity, consistency, and ensure accurate representation of diagnostic and treatment criteria.
…mark-screen-doesnt-work Fix bottom-nav interaction on Bookmarks screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Enhanced Custom Action Bar with Integrated Search and Redesigned Bookmark Dialog
Overview
This PR implements a comprehensive UI overhaul that matches Figma specifications. Link to design: https://www.figma.com/design/ZYZkodGKNJ3VOJMVlqdCMo/GA-TB-GUIDE-REDESIGN?node-id=2660-5103&m=dev
Before:

After:

Key Features
1. Custom Action Bar System
2. Integrated Search Functionality
3. Redesigned Bookmark Dialog
Files Modified
Core Architecture
app/src/main/java/org/apphatchery/gatbreferenceguide/ui/ActionBarController.kt- New interface for action bar controlapp/src/main/java/org/apphatchery/gatbreferenceguide/ui/BaseFragment.kt- Enhanced with action bar helper methodsapp/src/main/java/org/apphatchery/gatbreferenceguide/ui/MainActivity.kt- Complete action bar management systemLayout Files
app/src/main/res/layout/custom_action_bar_title.xml- Redesigned custom action bar layoutapp/src/main/res/layout/search_view.xml- New integrated search view componentapp/src/main/res/layout/fragment_body.xml- Updated to include search integrationapp/src/main/res/layout/dialog_bookmark.xml- Complete Figma-based redesignDrawable Resources
app/src/main/res/drawable/search_view_background.xml- Blue rectangular background for search containerapp/src/main/res/drawable/frame_16.xml- Gray background for search input fieldapp/src/main/res/drawable/rectangle_2.xml- White dialog background with rounded cornersapp/src/main/res/drawable/cancel_button_bg.xml- Gray cancel button backgroundapp/src/main/res/drawable/save_button_bg.xml- Blue save button backgroundapp/src/main/res/drawable/frame_46.xml- Gray text field background for bookmark dialogFragment Updates
app/src/main/java/org/apphatchery/gatbreferenceguide/ui/fragments/BodyFragment.kt- Search integration and title managementapp/src/main/java/org/apphatchery/gatbreferenceguide/ui/fragments/ChapterFragment.kt- Removed search iconapp/src/main/java/org/apphatchery/gatbreferenceguide/ui/fragments/SubChapterFragment.kt- Updated title handling and removed search iconTechnical Improvements
Action Bar Management
Dynamic Title System
Search Integration
Design Specifications Met
Bookmark Dialog Design
#ECECEC)#5182FF)User Experience Improvements
Navigation Flow
Bookmark Management
Testing Considerations
Breaking Changes